-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add class worker documentation #24849
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation about Worker class inherits from EventEmitter.
lpinca
reviewed
Dec 5, 2018
I corrected the parts you pointed out.
lpinca
approved these changes
Dec 11, 2018
vsemozhetbyt
approved these changes
Dec 11, 2018
vsemozhetbyt
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 11, 2018
Landed in 9fc0b7b |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Dec 11, 2018
Add documentation about Worker class inherits from EventEmitter. PR-URL: #24849 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
3 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Dec 17, 2018
Add documentation about Worker class inherits from EventEmitter. PR-URL: #24849 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Add documentation about Worker class inherits from EventEmitter. PR-URL: nodejs#24849 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
Add documentation about Worker class inherits from EventEmitter. PR-URL: #24849 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
Add documentation about Worker class inherits from EventEmitter. PR-URL: #24849 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Add documentation about Worker class inherits from EventEmitter. PR-URL: #24849 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
worker
Issues and PRs related to Worker support.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is repullrequest(#24809) because I did not read the document carefully and conflict occurred trying to fix. sorry, I am not used to git.
Add documentation about Worker class inherits from EventEmitter.
related #24732
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes