docs: edit LTS labels section #24369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixing the commit message, please hold |
mscdex
reviewed
Nov 15, 2018
| @@ -794,8 +794,8 @@ TSC for further discussion. | |||
|
|
|||
| #### How are LTS Branches Managed? | |||
|
|
|||
| There are multiple LTS branches, e.g. `v8.x` and `v6.x`. Each of these is paired | |||
| with a staging branch: `v8.x-staging` and `v6.x-staging`. | |||
| There are multiple LTS branches, e.g. `v10.x, `v8.x` and `v6.x`. Each of these is paired | |||
There was a problem hiding this comment.
Suggested change
| There are multiple LTS branches, e.g. `v10.x, `v8.x` and `v6.x`. Each of these is paired | |
| There are multiple LTS branches, e.g. `v10.x`, `v8.x` and `v6.x`. Each of these is paired |
|
These are labels, not tags. Also, since you are editing this section, could you remove the references to the labels for 4.x (we removed those labels, see #22406)? |
cfanoulis
changed the title
While checking the arguments passed to http.Server, the case where the options argument was of wrong type was not handled. Now it throws an ERR_INVALID_ARG_TYPE error if the options argument is not a function, object, null, or undefined. PR-URL: #24176 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #24257 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This reverts commit ac7450a. This fully reverts the changes to util.inspect depth. It has caused breakage in logging to existing apps, and even something as simple as `console.log(require)` will cause >1m freezes. I've heard nothing but negative feedback (seriously not a single person has expressed anything positive about this change) and personally i find this change extremely annoying. PR-URL: #24326 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: John-David Dalton <[email protected]>
PR-URL: #24322 Fixes: #24320 Fixes: #24362 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #24190 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #24179 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
ugh, updating the fork failed spectacuraly. WIll open a new PR since I neeed to fix this without polluting the commit history. Pardon the interruption, |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a reference for the v8 and v10 branches in the contributor guide, since the were... missing.
Checklist
cc: @nodejs/documentation