doc: Update collaborator guide with LTS labels #24379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit broke again, fixing now |
mscdex
reviewed
Nov 15, 2018
COLLABORATOR_GUIDE.md
Outdated
| in a future v6.x release | ||
| * `land-on-v4.x` - tells the release team that the commit should be landed | ||
| in a future v4.x release | ||
| in a future v6.x release |
There was a problem hiding this comment.
minor nit: there's an extra space added in the indentation here
mscdex
reviewed
Nov 15, 2018
COLLABORATOR_GUIDE.md
Outdated
| * `land-on-v10.x` - tells the release team that the commit should be landed | ||
| in a future v6.x release | ||
| * `land-on-v10.x` - tells the release team that the commit should be landed | ||
| in a future v6.x release |
Trott
reviewed
Nov 15, 2018
COLLABORATOR_GUIDE.md
Outdated
| * `land-on-v10.x` - tells the release team that the commit should be landed | ||
| in a future v6.x release | ||
| * `land-on-v10.x` - tells the release team that the commit should be landed | ||
| in a future v6.x release |
There was a problem hiding this comment.
Suggested change
| in a future v6.x release | |
| in a future v10.x release |
Trott
reviewed
Nov 15, 2018
COLLABORATOR_GUIDE.md
Outdated
| in a future v6.x release | ||
| * `land-on-v4.x` - tells the release team that the commit should be landed | ||
| in a future v4.x release | ||
| in a future v6.x release |
There was a problem hiding this comment.
Suggested change
| in a future v6.x release | |
| in a future v6.x release |
targos
reviewed
Nov 15, 2018
COLLABORATOR_GUIDE.md
Outdated
| considered for landing in the `v6.x-staging` branch. | ||
| * `land-on-v10.x` - tells the release team that the commit should be landed | ||
| in a future v6.x release | ||
| * `land-on-v10.x` - tells the release team that the commit should be landed |
There was a problem hiding this comment.
Suggested change
| * `land-on-v10.x` - tells the release team that the commit should be landed | |
| * `land-on-v8.x` - tells the release team that the commit should be landed |
targos
reviewed
Nov 15, 2018
COLLABORATOR_GUIDE.md
Outdated
| * `lts-watch-v6.x` - tells the LTS WG that the issue/PR needs to be | ||
| considered for landing in the `v6.x-staging` branch. | ||
| * `land-on-v10.x` - tells the release team that the commit should be landed | ||
| in a future v6.x release |
There was a problem hiding this comment.
Suggested change
| in a future v6.x release | |
| in a future v10.x release |
targos
reviewed
Nov 15, 2018
COLLABORATOR_GUIDE.md
Outdated
| * `land-on-v10.x` - tells the release team that the commit should be landed | ||
| in a future v6.x release | ||
| * `land-on-v10.x` - tells the release team that the commit should be landed | ||
| in a future v6.x release |
There was a problem hiding this comment.
Suggested change
| in a future v6.x release | |
| in a future v8.x release |
|
yep, cp broke, will be fixing |
|
all requested changes should have been addresed with the above commits, let me know if there is anything more |
richardlau
approved these changes
Nov 15, 2018
vsemozhetbyt
approved these changes
Nov 15, 2018
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
lpinca
approved these changes
Nov 15, 2018
|
Landed in ef3691a. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 16, 2018
PR-URL: nodejs#24379 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
PR-URL: #24379 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24379 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Dec 8, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
PR-URL: #24379 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #24379 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy/extension of PR #24369, I had to redo it because the commit history in my fork was broken
Checklist