Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: edit LTS labels section #24369

Closed
wants to merge 7 commits into from
Closed

docs: edit LTS labels section #24369

wants to merge 7 commits into from

Commits on Nov 14, 2018

  1. Configuration menu
    Copy the full SHA
    5fa001c View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2018

  1. http: else case is not reachable

    While checking the arguments passed to http.Server, the case where
    the options argument was of wrong type was not handled. Now it
    throws an ERR_INVALID_ARG_TYPE error if the options argument is
    not a function, object, null, or undefined.
    
    PR-URL: #24176
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    szabolcsit authored and cfanoulis committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    10a6a35 View commit details
    Browse the repository at this point in the history
  2. test: deep object to table not covered

    PR-URL: #24257
    Reviewed-By: Weijia Wang <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    ovhemert authored and cfanoulis committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    af864b8 View commit details
    Browse the repository at this point in the history
  3. Revert "util: change util.inspect depth default"

    This reverts commit ac7450a.
    
    This fully reverts the changes to util.inspect depth.
    
    It has caused breakage in logging to existing apps, and even
    something as simple as `console.log(require)` will cause >1m freezes.
    
    I've heard nothing but negative feedback (seriously not a single
    person has expressed anything positive about this change) and
    personally i find this change extremely annoying.
    
    PR-URL: #24326
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Franziska Hinkelmann <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: John-David Dalton <[email protected]>
    devsnek authored and cfanoulis committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    92beff9 View commit details
    Browse the repository at this point in the history
  4. timers: fix priority queue removeAt

    PR-URL: #24322
    Fixes: #24320
    Fixes: #24362
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Franziska Hinkelmann <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Weijia Wang <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    apapirovski authored and cfanoulis committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    887c490 View commit details
    Browse the repository at this point in the history
  5. lib: improved conditional check in zlib

    PR-URL: #24190
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    dYale authored and cfanoulis committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    37205b3 View commit details
    Browse the repository at this point in the history
  6. test: add typeerror for vm/compileFunction params

    PR-URL: #24179
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    dYale authored and cfanoulis committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    c0cd39b View commit details
    Browse the repository at this point in the history