[9.x] deps: V8: cherry-pick 8361fa58 from upstream #21293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofrobots sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
build
2 tasks
Original commit message: [runtime] Fix derived class instantiation Bug: chromium:806388 Change-Id: Ieb343f0d532c16b6102e85222b77713f23bacf8c Reviewed-on: https://chromium-review.googlesource.com/894942 Reviewed-by: Igor Sheludko <[email protected]> Commit-Queue: Camillo Bruni <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#50990}
ofrobots
force-pushed
the
backport/9/806388
branch
from
6c427fa
to
7d85eb0
Compare
|
Abandoning, as no more releases of 9.x are planned AFAIK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8.x: #21294
Original commit message:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @nodejs/v8-update
CI: https://ci.nodejs.org/job/node-test-pull-request/15466/
V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1424/