v6.13.1 proposal #19027
Merged
v6.13.1 proposal #19027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly handle IPv6 in Host header when setting servername. - When comparing IP addresses against addresses in the subjectAltName field of a certificate, format the address correctly before doing the string comparison. PR-URL: #14772 Fixes: #14736 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
Document and test the existing support for generic Duplex streams in the TLS module. PR-URL: #17599 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #17556 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #18007 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Jon Moss <[email protected]>
PR-URL: #17988 Fixes: #17986 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
PR-URL: #17379 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
After slicing, the `lastSegmentLength` should be calculated again, instead of assigning value `j`. PR-URL: #17974 Fixes: #17928 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
In the documentation for the buffer module, change instances of "the result is considered undefined behavior" to "the resulting behavior is undefined". It's less ambiguous in meaning and less awkward stylistically. PR-URL: #18091 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #18117 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #16539 Fixes: #16394 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #18097 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #18103 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fixes: #18116 PR-URL: #18121 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Weijia Wang <[email protected]>
Change many instances of "x is considered to be y" to "x is y". PR-URL: #18095 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The build breaks if there's a non-ASCII character on the path to the building directory. PR-URL: #16735 Refs: #16278 Refs: #14336 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Fixes: #12516 Refs: #2497 PR-URL: #17705 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add 8.x to the LTS versions that use a V8 branch that is not active anymore. PR-URL: #18155 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #18236 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #17326 Refs: #17169 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Use upper case variant in text in compliance with RFC 2898. PR-URL: #18279 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vladimir Kurchatkin <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
assert.strictEqual message argument removed to replace with default assert message to show the expected vs actual values PR-URL: #18259 Refs: #13296 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #18432 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Allows env vars to be passed through to child processes. This is needed for things like NODE_TEST_DIR or LD_LIBRARY_PATH if testing the shared library. Backport-PR-URL: #18883 PR-URL: #14822 Refs: #13390 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot
added
lib / src
MylesBorins
force-pushed
the
v6.13.1-proposal
branch
from
6bada2b
to
b01bd8a
Compare
MylesBorins
added a commit
that referenced
this pull request
Feb 27, 2018
Notable Changes: Coming Soon PR-URL: #19027
MylesBorins
force-pushed
the
v6.13.1-proposal
branch
from
b01bd8a
to
1246f72
Compare
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Notable Changes:
* http, tls:
- better support for IPv6 addresses (Mattias Holmlund)
nodejs#14772
PR-URL: nodejs#19027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-03-06, Version 6.13.1 'Boron' (LTS), @MylesBorins
Notable Changes
Coming Soon
Commits
d333ba5e2a] - doc: add vdeturckheim as collaborator (vdeturckheim) #184327fc5c69a4a] - doc: use PBKDF2 in text (Tobias Nießen) #182791e8d1200ce] - doc: Add example of null to assert.ifError (Leko) #1823646e43111af] - doc: V8 branch used in 8.x not active anymore (Franziska Hinkelmann) #18155b83b104c17] - doc: add builtin module in building.md (Suixinlei) #177052e76df5b4e] - doc: warn users about non-ASCII paths on build (Matheus Marchini) #167352c21421092] - doc: simplify sentences that use "considered" (Rich Trott) #180958f9362d6e8] - doc: add documentation for deprecation properties (Jon Moss) #165391505b71dab] - doc: add Leko to collaborators (Leko) #18117838f7bdb6e] - doc: be less tentative about undefined behavior (Rich Trott) #1809117c88c4c18] - doc: examples for fast-tracking regression fixes (Refael Ackermann) #17379e021fb73d2] - doc,test: mention Duplex support for TLS (Anna Henningsen) #17599df038ad90f] - fs: fix options.end of fs.ReadStream() (陈刚) #181218e7ac25aa6] - http, tls: better support for IPv6 addresses (Mattias Holmlund) #14772969c39eb3a] - lib: enable dot-notation eslint rule (Anatoli Papirovski) #1800737071b8dda] - path: fix path.normalize for relative paths (Weijia Wang) #17974fdf73b110f] - test: preserve env in test cases (Beth Griggs) #14822bb2d292562] - test: change assert message to default (ryanmahan) #1825927107b957c] - test: use countdown timer (Mandeep Singh) #17326eaa30e4947] - test: simplify loadDHParam in TLS test (Tobias Nießen) #181032004efded8] - test: improve to use template string (sreepurnajasti) #1809716ef24bccf] - test: use smaller input file for test-zlib.js (Rich Trott) #1798848790382f1] - tools: add number-isnan rule (Jon Moss) #17556