Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: examples for fast-tracking regression fixes #17379

Closed

Conversation

refack
Copy link
Contributor

@refack refack commented Nov 28, 2017

Follow up to #17332

Checklist
Affected core subsystem(s)

dec,meta

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 28, 2017
@refack refack added the meta Issues and PRs related to the general management of the project. label Nov 28, 2017
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks


* Focused changes that affect only documentation and/or the test suite:
* `code-and-learn` tasks typically fall into this category.
* `good-first-issue` pull requests may also be suitable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Pull requests from new contributors (for example code-and-learn tasks) that are low-risk and uncontentious.

  • If the aim is to improve the experience of your first node contribution, then let's say that specifically.
  • If we say docs or tests only, does that cover source comments? Or whitespace fixes? I feel like specifying the "what" is going to be too complex, but the "why" might be easier.

* `good-first-issue` pull requests may also be suitable.
* Changes that fix regressions:
* Regressions that break the workflow (red CI or broken compilation).
* Regressions that happen right before a release, or reported soon after.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe: "Fixes that need to be backported to a release line urgently."

If it's reported soon after a release and we decided to leave it till the next one, then it doesn't need to be fast-tracked IMO.

Copy link
Member

@joyeecheung joyeecheung Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just listing changes that "can be" fast-tracked, not necessarily "need to be"?

jasnell pushed a commit that referenced this pull request Jan 10, 2018
PR-URL: #17379
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 10, 2018

Landed in 4c8bedf

@jasnell jasnell closed this Jan 10, 2018
evanlucas pushed a commit that referenced this pull request Jan 22, 2018
PR-URL: #17379
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
PR-URL: #17379
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
PR-URL: #17379
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
PR-URL: #17379
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Feb 27, 2018
@refack refack deleted the COLLABORATOR_GUIDE-fast-track-reversions branch September 5, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants