test: change assert message to default #18259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assert.strictEqual message argument removed to replace with default assert message to show the expected vs actual values Refs: nodejs#13296
lpinca
approved these changes
Jan 19, 2018
| assert.strictEqual( | ||
| expected, | ||
| '/caf\u{e9}\u{1f436}', | ||
| 'Sanity check that string literal produced the expected string' | ||
| '/caf\u{e9}\u{1f436}' |
There was a problem hiding this comment.
Nit: can you please swap the arguments (actual first expected second) and put everything on the same line now that it doesn't take more than 80 chars? Thank you.
Condensed line 14 assert to one line
Leko
approved these changes
Jan 20, 2018
maclover7
approved these changes
Jan 20, 2018
maclover7
added
the
author ready
BridgeAR
reviewed
Jan 21, 2018
| '/caf\u{e9}\u{1f436}', | ||
| 'Sanity check that string literal produced the expected string' | ||
| ); | ||
| //Sanity check for café🐶 is café🐶 |
There was a problem hiding this comment.
The comment is actually not even necessary. It will be printed in case of a error and the expected value is visible as well.
cjihrig
approved these changes
Jan 21, 2018
jasnell
approved these changes
Jan 22, 2018
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jan 23, 2018
assert.strictEqual message argument removed to replace with default assert message to show the expected vs actual values PR-URL: nodejs#18259 Refs: nodejs#13296 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in f5d9169. |
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
assert.strictEqual message argument removed to replace with default assert message to show the expected vs actual values PR-URL: #18259 Refs: #13296 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
assert.strictEqual message argument removed to replace with default assert message to show the expected vs actual values PR-URL: #18259 Refs: #13296 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
assert.strictEqual message argument removed to replace with default assert message to show the expected vs actual values PR-URL: #18259 Refs: #13296 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
assert.strictEqual message argument removed to replace with default assert message to show the expected vs actual values PR-URL: nodejs#18259 Refs: nodejs#13296 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert.strictEqual message argument removed to replace
with default assert message to show the expected vs
actual values
Refs: #13296
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test