Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v7.9.0 Release Proposal #12319

Merged
merged 59 commits into from
Apr 11, 2017
Merged

v7.9.0 Release Proposal #12319

merged 59 commits into from
Apr 11, 2017

Conversation

italoacasas
Copy link
Contributor

@italoacasas italoacasas commented Apr 10, 2017 •
edited
Loading

2017-04-11, Version 7.9.0 (Current), @italoacasas

Notable Changes

  • util: console is now closer to what is supported in all major browsers (Roman Reiss) #10308

Tests

Commits

Semver Minor
Semver Patch

targos and others added 30 commits April 10, 2017 08:32
@targos
doc: add deprecations page to docs toc
5ac719d 
PR-URL: #12268
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@silverwind @italoacasas
util: add %i and %f formatting specifiers
1ee38eb 
This change brings formatting specifiers available in `util.format` and
consequently, `console.*` closer to what is supported in all major
browsers.

- `%i` is introduced to format integer values.
- `%f` is introduced to format floating point values.

Fixes: #10292
PR-URL: #10308
Reviewed-By: James M Snell <[email protected]>
@danbev @italoacasas
deps: backport 8dde6ac from upstream V8
6130d54 
Commit 9c9e2d7 changed the name of TypeFeedbackVector to
FeedbackVector but that commit did not update gdbinit. This applies the
changed to gdbinit from upstream V8.

Original commit message:

[gdbinit] Rename TypeFeedback* to Feedback*.

    BUG=

    Change-Id: I1e32fdcf9edda57f5de329c8b694620a5da4558b
    Reviewed-on: https://chromium-review.googlesource.com/442444
    Reviewed-by: Michael Stanton <[email protected]>
    Commit-Queue: Igor Sheludko <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#43185}

PR-URL: #12060
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@srl295 @italoacasas
tools: add missing #include "unicode/putil.h"
fdf76d5 
* we use u_setDataDirectory() in "unicode/putil.h"
* at present, this header is indirectly included,
  but this will change in ICU 59
* no impact on past ICUs.
* this is an exact analog to #11753

PR-URL: #12078
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott @italoacasas
test: fix flaky child-process-exec-kill-throws
87ca9a6 
This is a fix for test-child-process-exec-kill-throws which is currently
flaky on Windows.

A bug in the test was causing the child process to fail for reasons
other than those intended by the test. Instead of failing for exceeding
the `maxBuffer` setting, the test was failing because it was trying to
load `internal/child_process` without being passed the
`expose-internals` flag. Move that module to where only the parent
process (which gets the flag) loads it.

Additionally, improve an assertion message to help debug problems like
this.

PR-URL: #12111
Fixes: #12053
Reviewed-By: Richard Lau <[email protected]>
@targos @italoacasas
tools: update dotfile whitelist in .gitignore
8823861 
.eslintrc was renamed in #7699 to .eslintrc.yaml.

PR-URL: #12116
Refs: #7699
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@seishun @italoacasas
src: fix base64 decoding
ffbcfdf 
Make sure trailing garbage is not treated as a valid base64 character.

Fixes: #11987
PR-URL: #11995
Reviewed-By: Anna Henningsen <[email protected]>
@AnnaMag @italoacasas
vm: use SetterCallback to set func declarations
2f88de1 
Currently, when in strict mode, function
declarations are copied on the sandbox by
CopyProperties(), which is not necessary
and will break when CP is removed.

This change maintains current behavior,
letting GlobalPropertySetterCallback
copy functions on the sandbox instead
of using CP to do the task.

PR-URL: #12051
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@joyeecheung @italoacasas
net: rename internal functions for readability
305f822 
* Rename listen to listenInCluster
* Rename _listen2 to _setupListenHandle
* Remove _listen since it's a one-liner only used in one place
* Correct comments in server.listen

PR-URL: #11796
Reviewed-By: James M Snell <[email protected]>
@silverwind @italoacasas
doc: add logo to README
b5283f9 
Adds a centered logo to the README to make it a little more festive. As
centering is not possible in pure Markdown, a bit of HTML is used.

PR-URL: #12148
Ref: #6920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@watilde @italoacasas
test: synchronize WPT url setter test data
6ccbf38 
Updates:
+ Bring tests url-setter-tests from WPT, and put it as JavaScript
+ Comment out unpassed tests

Refs: web-platform-tests/wpt#5112
Refs: #11887
PR-URL: #12058
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@thefourtheye @italoacasas
test: reduce buffer size in buffer-creation test
b52b3f6 
This test is allocating much more memory than necessary to actually
reproduce the original problem. Lowering the amount of memory allocated
increases performance at least in some cases and makes this test less
likely to time out on SmartOS.

PR-URL: #11177
Ref: #10166

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Julien Gilli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@gibfahn @italoacasas
doc, inspector: note that the host is optional
3af9101 
Document that `node --inspect=${port}` is also a viable option.

PR-URL: #12149
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn @italoacasas
build: use $(RM) in Makefile for consistency
72a27b3 
Also allows someone to reassign `$RM`, e.g. with `RM=rm -v` instead of
`rm -f` (the default) should they want to. We're currently using a
mixture of `$(RM)` and `rm -f`.

There are a couple of places which aren't doing -f, have them do it for
consistency.

PR-URL: #12157
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@santigimeno @italoacasas
test: fix flaky test-child-process-exec-timeout
b15dc95 
At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM
to a process that is still starting up kills it with SIGKILL instead of
SIGTERM.

PR-URL: #12159
Refs: libuv/libuv#1226
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@vsemozhetbyt @italoacasas
benchmark: replace [].join() with ''.repeat()
f057cc3 
Also add a benchmark to compare both ways to create strings.

PR-URL: #12170
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@vsemozhetbyt @italoacasas
doc: fix and update examples in http.md
d6e9cf7 
* replace `var` by `const` in http.md
* replace `let` by `const` in http.md
* fix spaces in code examples of http.md
* replace console.log() by .error() in http.md
* make arrow function clearer in http.md
* use object destructuring in http.md
* update output examples in http.md

PR-URL: #12169
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@DavidCai1111 @italoacasas
test: increase querystring coverage
fb34d9c 
PR-URL: #12163
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@aqrln @italoacasas
buffer: optimize decoding wrapped base64 data
805ebef 
The fast base64 decoder used to switch to the slow one permanently when
it saw a whitespace or other garbage character.  Since the most common
situation such characters may be encountered in is line-wrapped base64
data, a more profitable strategy is to decode a single 24-bit group with
the slow decoder and then continue running the fast algorithm.

PR-URL: #12146
Ref: #12114
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@refack @italoacasas
test: performance, remove Popen(shell=True) on Win
9e6b0a4 
not needed according to official python docs -
https://docs.python.org/2/library/subprocess.html#index-2

PR-URL: #12138
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Nikolai Vavilov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@raphaelokon @italoacasas
doc: add notes to http.get options
36617fd 
Extra notes that options doesn't include the prototype when copied

Fixes: #12092
PR-URL: #12124
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@italoacasas
doc: update Mac OS X references in releases.md
731a200 
This commit updates 3 additional references to Mac OS X in
releases.md to macOS.

PR-URL: #12106
Fixes: #12086
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott @italoacasas
tools: update ESLint to 3.19.0
8058bae 
PR-URL: #12162
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@lpinca @italoacasas
events: do not keep arrays with a single listener
c814c7e 
Use the remaining listener directly if the array of listeners has only
one element after running `EventEmitter.prototype.removeListener()`.

Advantages:

- Better memory usage and better performance if no new listeners are
  added for the same event.

Disadvantages:

- A new array must be created if new listeners are added for the same
  event.

PR-URL: #12043
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ron Korving <[email protected]>
@darai0512 @italoacasas
doc: fix fs.read arg type
806c4f3 
About fs.read's 2nd argument, string is invalid.

PR-URL: #12034
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@darai0512 @italoacasas
doc: fix the timing of setImmediate's execution
cf1117b 
About setImmediate, the execution timing is after timers currently.

PR-URL: #12034
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos @italoacasas
benchmark: avoid TurboFan deopt in arrays bench
6083e7a 
Something unidentified at the moment is causing the arrays benchmarks to
deopt when run with the TurboFan compiler. Refactor the test to use an
inner function that can be correctly optimized by TurboFan and
Crankshaft.

PR-URL: #11894
Ref: #11851 (comment)
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@refack @italoacasas
test: more robust check for location of node.exe
a11ed6a 
look for the actual produced `exe` not just the directory

PR-URL: #12120
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Nikolai Vavilov <[email protected]>
@Minimalistic @italoacasas
doc: add table of contents to README.md
961c89c 
PR-URL: #11635
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@aqrln @italoacasas
test: add Unicode characters regression test
8caf6fd 
This test ensures that UTF-8 characters can be used in core JavaScript
modules built into Node's binary.

PR-URL: #11423
Ref: #11129
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. v7.x v8 engine Issues and PRs related to the V8 dependency. labels Apr 10, 2017
@italoacasas italoacasas removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency. labels Apr 10, 2017
DavidCai1111 and others added 4 commits April 10, 2017 18:40
@DavidCai1111 @italoacasas
test: add internal/socket_list tests
b997e62 
PR-URL: #12109
Reviewed-By: James M Snell <[email protected]>
@Trott @italoacasas
tools: ignore URLs in line length linting
77353b3 
Where inclusion of a lengthy URL causes a line to exceed 80 characters
in our code base, do not report the line length as a linting error.

PR-URL: #11890
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@vsemozhetbyt @italoacasas
benchmark: add final clean-up to module-loader.js
211dd16 
PR-URL: #12102
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@ofrobots @italoacasas
deps: cherry-pick 22858cb from V8 upstream
9f73df5 
Original commit message:
  Only flush not yet started and finished compile jobs from gc

  We shouldn't block during GC for arbitrarily long intervals.

  BUG=chromium:686153,chromium:642532
  [email protected],[email protected]

  Review-Url: https://codereview.chromium.org/2658313002
  Cr-Commit-Position: refs/heads/master@{#42761}

PR-URL: #11998
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aqrln
Copy link
Contributor

aqrln commented Apr 11, 2017

PRs against current v7.x-staging fail on node-test-commit-linux (ubuntu1204-clang341-64) with

clang: warning: argument unused during compilation: '-I ../deps/v8'
In file included from ../deps/v8/src/base/functional.cc:11:
In file included from ../deps/v8/src/base/functional.h:11:
/usr/bin/../lib/gcc/x86_64-linux-gnu/4.9/../../../../include/c++/4.9/cstddef:51:11: error: no member named 'max_align_t' in the global namespace
  using ::max_align_t;
        ~~^
1 error generated.

@italoacasas
Copy link
Contributor Author

@aqrln where are you seeing that?

@mscdex
Copy link
Contributor

mscdex commented Apr 11, 2017

@aqrln According to @MylesBorins it may be a known "issue."

@aqrln
Copy link
Contributor

aqrln commented Apr 11, 2017

@italoacasas

@italoacasas
Copy link
Contributor Author

cc @nodejs/build @MylesBorins ^^^

@aqrln
Copy link
Contributor

aqrln commented Apr 11, 2017

@mscdex ah, I see, didn't know it had already been reported. Thanks.

@italoacasas
2017-04-11, Version 7.9.0 (Current)
0794478 
Notable changes:

* util: console is now closer to what is supported in all major browsers
(Roman Reiss) [#10308](#10308)

PR-URL: #12319
@italoacasas italoacasas merged commit 0794478 into v7.x Apr 11, 2017
italoacasas added a commit to italoacasas/node that referenced this pull request Apr 11, 2017
@italoacasas
Working on v7.9.1
675ece4 
PR-URL: nodejs#12319
italoacasas added a commit to italoacasas/node that referenced this pull request Apr 11, 2017
@italoacasas
2017-04-11, Version 7.9.0 (Current)
b8f4160 
Notable changes:

* util: console is now closer to what is supported in all major browsers
(Roman Reiss) [nodejs#10308](nodejs#10308)

PR-URL: nodejs#12319
italoacasas added a commit to italoacasas/nodejs.org that referenced this pull request Apr 11, 2017
@italoacasas
blog: release post for v7.9.0
8283e4f 
PR-URL: nodejs/node#12319
@italoacasas italoacasas mentioned this pull request Apr 11, 2017
Merged
italoacasas added a commit to nodejs/nodejs.org that referenced this pull request Apr 11, 2017
@italoacasas
blog: release post for v7.9.0 (#1200)
ba75fe1 
PR-URL: nodejs/node#12319
@addaleax addaleax deleted the v7.9.0-propsal branch April 11, 2017 19:39
imyller pushed a commit to imyller/meta-nodejs that referenced this pull request Apr 20, 2017
@imyller
2017-04-11, Version 7.9.0 (Current)
d10fd71 
    Notable changes:

    * util: console is now closer to what is supported in all major browsers
    (Roman Reiss) [#10308](nodejs/node#10308)

    PR-URL: nodejs/node#12319

Signed-off-by: Ilkka Myller <[email protected]>
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@italoacasas @evanlucas
2017-04-11, Version 7.9.0 (Current)
7db0af6 
Notable changes:

* util: console is now closer to what is supported in all major browsers
(Roman Reiss) [#10308](#10308)

PR-URL: #12319
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@italoacasas @evanlucas
Working on v7.9.1
da50af6 
PR-URL: #12319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@italoacasas italoacasas

Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.