-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What does SecureContext::EnableTicketKeyCallback do? #13176
Comments
addaleax
added
crypto
Issues and PRs related to the crypto subsystem.
question
Issues that look for answers.
labels
May 23, 2017
It is needed only for testing as it is now. There is just no other way to write a regression test for that problem. If someone will ever request an API for this, we should make it public. Otherwise, let's keep it for private use. |
4 tasks
addaleax
added a commit
to addaleax/node
that referenced
this issue
May 24, 2017
2 tasks
jasnell
pushed a commit
that referenced
this issue
May 28, 2017
Fixes: #13176 PR-URL: #13193 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Jul 17, 2017
Fixes: #13176 PR-URL: #13193 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
This was referenced Jun 21, 2023
This was referenced Jun 22, 2023
This was referenced Jun 22, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
e83a41a introduced an internal
enableTicketKeyCallback
method onSecureContext
s, without documentation or usage in JS land. It’s only mentioned in one of the test files,test/parallel/test-https-resume-after-renew.js
. So … Should this functionality stay? Should it go? And generally, what is it?I stumbled upon this while looking into #13142 (comment) to see whether
SecureContext
should inherit fromAsyncWrap
, but I can’t really tell how theMakeCallback
there works and whether it should really be one, so I thought it might be good to just ask about it.@indutny @nodejs/crypto
The text was updated successfully, but these errors were encountered: