async_hooks: implement C++ embedder API #13142

addaleax · 2017-05-21T18:15:55Z

~~This is based on top of the current version of #13000, and currently still missing tests.~~

/cc @nodejs/diagnostics and in particular @AndreasMadsen @trevnorris @matthewloring @danbev

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

async_hooks

addaleax

I’ve got a few questions about edge cases where it would be cool if @AndreasMadsen or @trevnorris could chime in.

Also, I can open a separate PR for cfe5d401921e72af3f6dc03a5a373401ba4e32e8 because it’s not really related to the rest here, and could be backported to all release lines if you think that makes sense.

addaleax · 2017-05-21T18:18:28Z

src/node.cc

+               env->immediate_callback_string(),
+               0,
+               nullptr,
+               0).ToLocalChecked();


There should be no async hooks firing for the call that runs setImmediate() timers, right?

sigh, I think this is correct. /cc @Fishrock123

addaleax · 2017-05-21T18:20:05Z

src/node.cc

-  MakeCallback(env, process_object, "emit", arraysize(args), args);
+  MakeCallback(env->isolate(),
+               process_object, "emit", arraysize(args), args,
+               0).ToLocalChecked();


I’m really not sure whether 0 is correct here.

Good question. In theory, we should only have 0 as the id when the resource is unknown, which should only happen because of legacy code.

I'm not really sure what the appropriate resource is, I guess we could create an event-loop resource on startup.

addaleax · 2017-05-21T18:20:32Z

src/node_crypto.cc

                                        sc->object(),
                                        env->ticketkeycallback_string(),
                                        arraysize(argv),
-                                        argv);
+                                        argv,
+                                        0).ToLocalChecked();


If SecureContext inherits from AsyncWrap as @trevnorris suggests this problem should be solved.

See #13176, I don’t think we need to actually care about this

trevnorris · 2017-05-23T07:39:17Z

src/node_crypto.cc

-  Local<Value> ret = node::MakeCallback(env,
+
+  // TODO(addaleax): `SecureContext` should maybe inherit from AsyncWrap?
+  Local<Value> ret = node::MakeCallback(env->isolate(),


Hm. I missed this. This should inherit from AsyncWrap.

danbev · 2017-05-23T12:34:41Z

src/node.h

+                                       async_uid asyncId,
+                                       async_uid triggerId = -1);
+
+/* Helper class users can inherit from, but is not necessary. If


Suggestion: Helper class users can optionally inherit from.

AndreasMadsen

Thanks for taking the time to implement this, here is my initial review:

Can we not use DomainEnter and DomainExit in MakeCallback?
How is the trigger set in the Init emit? set_init_trigger_id is not a public API, I think we need to make trigger_id an option in EmitAsyncInit and AsyncResource::AsyncResource. That should also allow us to remove trigger_id from AsyncResource::MakeCallback.

AndreasMadsen · 2017-05-24T10:11:30Z

src/node.h

+/* Helper class users can optionally inherit from. If
+ * `AsyncResource::MakeCallback()` is used, then all four callbacks will be
+ * called automatically. */
+class AsyncResource {


In the JS Embedder API this is called AsyncEvent, I actually like the AsyncResource name better, but at the very least it is inconsistent.

addaleax · 2017-05-24T11:19:05Z

Can we not use DomainEnter and DomainExit in MakeCallback?

Can you be a bit more specific why we wouldn’t want to use these?

In the JS Embedder API this is called AsyncEvent, I actually like the AsyncResource name better, but at the very least it is inconsistent.

#13192

AndreasMadsen · 2017-05-24T11:26:46Z

Can you be a bit more specific why we wouldn’t want to use these?

Sorry, I think I messed up in language negatives. I meant:

Can we ~~not~~ use DomainEnter and DomainExit in MakeCallback?

addaleax · 2017-05-24T11:38:54Z

think we need to make trigger_id an option in EmitAsyncInit and AsyncResource::AsyncResource

done

Can we ~~not~~ use DomainEnter and DomainExit in MakeCallback?

done!

AndreasMadsen · 2017-05-24T11:50:26Z

src/node.h

+        async_uid trigger_id = -1) {
+      return node::MakeCallback(isolate_, get_resource(),
+                                callback, argc, argv,
+                                uid_, trigger_id);


The trigger_id passed to AsyncResource::MakeCallback should be the same as the one passed to AsyncResource::AsyncResource, so I think we should just store trigger_id in a private field in AsyncResource::AsyncResource and use that field in AsyncResource::MakeCallback.

That way we don't need the trigger_id argument in AsyncResource::MakeCallback.

Done, although I have to admit I’m not a hundred percent sure what the semantics of trigger_id in before/after hooks would be if the value is always the same that was passed for the init hook … maybe I share @joshgav’s confusion about it? ;)

addaleax added the wip Issues and PRs that are still a work in progress. label May 21, 2017

addaleax commented May 21, 2017

View reviewed changes

trevnorris reviewed May 23, 2017

View reviewed changes

danbev approved these changes May 23, 2017

View reviewed changes

addaleax mentioned this pull request May 23, 2017

src: make StreamBase::GetAsyncWrap pure virtual #13174

Closed

2 tasks

addaleax added the blocked PRs that are blocked by other issues or PRs. label May 23, 2017

AndreasMadsen removed the inspector Issues and PRs related to the V8 inspector protocol label May 23, 2017

addaleax mentioned this pull request May 23, 2017

What does SecureContext::EnableTicketKeyCallback do? #13176

Closed

AndreasMadsen reviewed May 24, 2017

View reviewed changes

addaleax force-pushed the async-hooks-native-api branch from e6c71b6 to de2fba0 Compare May 24, 2017 11:32

AndreasMadsen reviewed May 24, 2017

View reviewed changes

AndreasMadsen mentioned this pull request May 24, 2017

[async_hooks] tracking issue nodejs/diagnostics#29

Closed

27 tasks

addaleax removed the crypto Issues and PRs related to the crypto subsystem. label May 25, 2017

addaleax force-pushed the async-hooks-native-api branch from 48a3c4f to 616a20f Compare May 25, 2017 18:03

kissofire mentioned this pull request Jun 25, 2023

[Snyk] Fix for 28 vulnerabilities kissofire/node#102

Open

leonardoadame mentioned this pull request Nov 30, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#332

Open

aliscco mentioned this pull request Dec 1, 2023

[Snyk] Security upgrade jest from 26.4.2 to 29.0.0 aliscco/alisco-node#924

Open

aliscco mentioned this pull request Dec 2, 2023

[Snyk] Fix for 6 vulnerabilities aliscco/alisco-node#1050

Open

leonardoadame mentioned this pull request Dec 3, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#477

Open

This was referenced May 14, 2024

[Snyk] Fix for 2 vulnerabilities leonardoadame/node#879

Open

[Snyk] Security upgrade jest from 28.1.3 to 29.0.0 leonardoadame/node#918

Open

aliscco mentioned this pull request May 15, 2024

[Snyk] Security upgrade jest from 26.4.2 to 29.0.0 aliscco/alisco-node#1535

Open

This was referenced May 16, 2024

[Snyk] Security upgrade jest from 27.5.1 to 29.0.0 leonardoadame/node#946

Open

[Snyk] Fix for 4 vulnerabilities leonardoadame/node#966

Open

aliscco mentioned this pull request May 17, 2024

[Snyk] Security upgrade jest from 26.4.2 to 29.0.0 aliscco/alisco-node#1603

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

async_hooks: implement C++ embedder API #13142

async_hooks: implement C++ embedder API #13142

addaleax commented May 21, 2017 •

edited

Loading

addaleax left a comment •

edited

Loading

addaleax May 21, 2017

AndreasMadsen May 26, 2017

addaleax May 21, 2017

AndreasMadsen May 24, 2017

addaleax May 21, 2017

AndreasMadsen May 24, 2017

addaleax May 24, 2017

trevnorris May 23, 2017

danbev May 23, 2017

addaleax May 23, 2017

AndreasMadsen left a comment •

edited

Loading

AndreasMadsen May 24, 2017

addaleax commented May 24, 2017

AndreasMadsen commented May 24, 2017

addaleax commented May 24, 2017

AndreasMadsen May 24, 2017 •

edited

Loading

addaleax May 24, 2017

async_hooks: implement C++ embedder API #13142

async_hooks: implement C++ embedder API #13142

Conversation

addaleax commented May 21, 2017 • edited Loading

Checklist

Affected core subsystem(s)

addaleax left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndreasMadsen left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

addaleax commented May 24, 2017

AndreasMadsen commented May 24, 2017

addaleax commented May 24, 2017

AndreasMadsen May 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

addaleax commented May 21, 2017 •

edited

Loading

addaleax left a comment •

edited

Loading

AndreasMadsen left a comment •

edited

Loading

AndreasMadsen May 24, 2017 •

edited

Loading