src: add comment for TicketKeyCallback #13193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
lpinca
approved these changes
May 24, 2017
refack
reviewed
May 24, 2017
| @@ -1202,6 +1202,8 @@ void SecureContext::SetFreeListLength(const FunctionCallbackInfo<Value>& args) { | |||
| } | |||
|
|
|||
|
|
|||
| // Currently, EnableTicketKeyCallback and TicketKeyCallback are only present for | |||
| // the regression test in test/parallel/test-https-resume-after-renew.js. | |||
There was a problem hiding this comment.
[suggestion] If i understand this case correctly add , they are considered private until decided otherwise.
Also maybe add _ to the JS binding.
There was a problem hiding this comment.
I think it’s implied that they are private when they are only there for tests. Also, this is only on the _handle property, so I think we’re good.
refack
approved these changes
May 24, 2017
cjihrig
approved these changes
May 24, 2017
|
Landed in e2f2d18 |
addaleax
added a commit
that referenced
this pull request
May 26, 2017
Fixes: #13176 PR-URL: #13193 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
Fixes: #13176 PR-URL: #13193 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
Fixes: #13176 PR-URL: #13193 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
This was referenced Jun 21, 2023
This was referenced Jun 21, 2023
This was referenced Jun 22, 2023
This was referenced Jun 22, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13176
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src/crypto