Propose v3.3.2

[Fishrock123]

It's been a while, we should get the fixes in the wild.

Just doing this here to make sure there weren't any loose ends to clean up and that 3.3.2 would be the correct version.

cc @bnoordhuis / @orangemocha

[rvagg]

+1

• [f31482e226] - win: work around __pfnDliNotifyHook2 type change (Alexis Campailla) #952
• [3df8222fa5] - Allow for [email protected] (Rebecca Turner) #950
• [a4fa07b390] - More verbose error on locating msbuild.exe failure. (Mateusz Jaworski) #930
• [4ee31329e0] - doc: add command options to README.md (Gibson Fahnestock) #937
• [c8c7ca86b9] - Add --silent option for zero output. (Gibson Fahnestock) #937
• [ac29d23a7c] - Upgrade to [email protected]. (Ben Noordhuis) #943
• [15fd56be3d] - Enable V8 deprecation warnings for native modules (Matt Loring) #920
• [7f1c1b960c] - gyp: improvements for android generator (Robert Chiras) #935
• [088082766c] - Update Windows install instructions (Sara Itani) #867
• [625c1515f9] - gyp: inherit CC/CXX for CC/CXX.host (Johan Bergström) #908
• [3bcb1720e4] - Add support for the Python launcher on Windows (Patrick Westerhoff) [#890 Add support for the Python launcher on Windows #894](#890 Add support for the Python launcher on Windows #894

After this I reckon we should bump to v4 and get rid of the NVM env stuff.

[bnoordhuis]

I'd like to wait until #915 and #955 have landed. It'd be nice if someone could review #915.

[orangemocha]

It looks like #915 has landed, but #955 is still pending.

I would like to point out that once VS 2015 Update 3 hits RTM (it's currently in RC), we are probably going to get a lot of bug reports because of #949 (which is fixed by f31482e226).

This release (or at least f31482e226) will need to be propagated to all of Node release lines.

[rvagg]

v3.4.0 published, changelog @ https://github.com/nodejs/node-gyp/blob/master/CHANGELOG.md

[rvagg]

npm/npm#13199 & npm/npm#13200

[shiftkey]

Just a heads up - AppVeyor has made VS2015 Update 3 available on their default images, and with the use of Node v6.2.2 it is now encountering the issue logged in #949, causing anything which depends on node-gyp v3.3.1 (in my case, keytar) to fail with a compilation error.

C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\src\win_delay_load_hook.c(34): error C2373: '__pfnDliNotifyHook2': redefinition; different type modifiers [C:\Users\shiftkey\Documents\GitHub\desktop\node_modules\keytar\build\keytar.vcxproj]

Are there any known workarounds to get up to node-gyp v3.4.0 while we wait for this new release to flow upstream?

[bnoordhuis]

@shiftkey Untested, but I would expect that you can npm install [email protected] as a build_script cmd in your appveyor.yml.

[shiftkey]

@bnoordhuis thanks for the suggestion, but sadly that - whether providing -g or not - doesn't seem to override the behaviour of npm install. Oh well.

[rvagg]

@shiftkey you're going to have to be patient for this process to work itself out. We have it going in to the next npm releases (already in npm@2 to be released next week, in the process of getting in to npm@3) and then after that it'll have to come across to node for inclusion in a new release. When it's in npm you should be able to manually upgrade npm to make it work and not have to wait for Node to upgrade it's npm but you'll have to keep an eye on npm/npm#13199 & npm/npm#13200.

[beatgrabe]

@shiftkey As a workaround I can propose this:

1. Go to your folder where npm is installed, e.g.:
   C:\Program Files\nodesjs\node_modules\npm
2. Open: package.json
3. Dump entry for node-gyp in bundleDependencies
4. Bump version number to 3.4.0 for node-gyp in dependencies
5. Make a npm i in this directory to install [email protected] to fix the problem

Relating SO Quesion