Skip to content

Commit

Permalink
Enable V8 deprecation warnings for native modules
Browse files Browse the repository at this point in the history
It will be helpful for native module developers to be aware of any
deprecated apis they are using so that they can update before their
modules break completely. Module developers can override this option
in their binding.gyp if they do not want to see these warnings.

PR-URL: #920
Reviewed-By: Ben Noordhuis <[email protected]>
  • Loading branch information
Matt Loring authored and bnoordhuis committed May 30, 2016
1 parent 7f1c1b9 commit 15fd56b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion addon.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
'<(node_root_dir)/deps/v8/include'
],
'defines': [
'NODE_GYP_MODULE_NAME=>(_target_name)'
'NODE_GYP_MODULE_NAME=>(_target_name)',
# Warn when using deprecated V8 APIs.
'V8_DEPRECATION_WARNINGS=1'
],

'target_conditions': [
Expand Down

0 comments on commit 15fd56b

Please sign in to comment.