gyp: improvements for android generator #935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating Android.mk files for HOST binaries, we need to specify the LOCAL_CXX_STL to use when linking. Also, set the variable GYP_HOST_MULTILIB to 'first'. This is used as LOCAL_MULTILIB, and since we don't provide flags for both types of builds (32-bit and 64-bit), the build system will try to build both and fail. More details about LOCAL_MULTILIB can be found here: https://source.android.com/source/64-bit-builds.html Signed-off-by: Robert Chiras <[email protected]>
|
cc @bnoordhuis? |
bnoordhuis
pushed a commit
that referenced
this pull request
May 19, 2016
When generating Android.mk files for HOST binaries, we need to specify the LOCAL_CXX_STL to use when linking. Also, set the variable GYP_HOST_MULTILIB to 'first'. This is used as LOCAL_MULTILIB, and since we don't provide flags for both types of builds (32-bit and 64-bit), the build system will try to build both and fail. More details about LOCAL_MULTILIB can be found here: https://source.android.com/source/64-bit-builds.html Signed-off-by: Robert Chiras <[email protected]> PR-URL: #935 Reviewed-By: Ben Noordhuis <[email protected]>
|
Rubber-stamp LGTM. Landed in 7f1c1b9, thanks Robert. |
Closed
refack
pushed a commit
to refack/node-gyp
that referenced
this pull request
Apr 23, 2017
When generating Android.mk files for HOST binaries, we need to specify the LOCAL_CXX_STL to use when linking. Also, set the variable GYP_HOST_MULTILIB to 'first'. This is used as LOCAL_MULTILIB, and since we don't provide flags for both types of builds (32-bit and 64-bit), the build system will try to build both and fail. More details about LOCAL_MULTILIB can be found here: https://source.android.com/source/64-bit-builds.html Signed-off-by: Robert Chiras <[email protected]> PR-URL: nodejs#935 Reviewed-By: Ben Noordhuis <[email protected]>
refack
pushed a commit
to refack/node-gyp
that referenced
this pull request
Aug 19, 2017
When generating Android.mk files for HOST binaries, we need to specify the LOCAL_CXX_STL to use when linking. Also, set the variable GYP_HOST_MULTILIB to 'first'. This is used as LOCAL_MULTILIB, and since we don't provide flags for both types of builds (32-bit and 64-bit), the build system will try to build both and fail. More details about LOCAL_MULTILIB can be found here: https://source.android.com/source/64-bit-builds.html Signed-off-by: Robert Chiras <[email protected]> PR-URL: nodejs#935 Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating Android.mk files for HOST binaries, we need to specify
the LOCAL_CXX_STL to use when linking.
Also, set the variable GYP_HOST_MULTILIB to 'first'. This is used as
LOCAL_MULTILIB, and since we don't provide flags for both types of
builds (32-bit and 64-bit), the build system will try to build both and
fail.
More details about LOCAL_MULTILIB can be found here:
https://source.android.com/source/64-bit-builds.html
Signed-off-by: Robert Chiras [email protected]