Prepare for image becoming official (change links, image id, etc.)

[pesho]

If/when the image becomes "docker official", some links/ids will have to change. Also, the "Supported tags" README section will be obsolete, as it will be auto-generated in docker-library/docs. This pull request prepares for when this happens.

[rvagg]

this is a bit premature isn't it? afaik it's not safe to assume this will become the official repo, from the look of the discussion they are talking about maintaining their own official one separate to this.

[pesho]

this is a bit premature isn't it? afaik it's not safe to assume this will become the official repo

Yes, this wasn't intended to be merged until the repo actually became official.

from the look of the discussion they are talking about maintaining their own official one separate to this

Not really, this repo will still be the definitive source for the image. The process is a bit different for official images, I had posted links to docs in #1

[pesho]

@wblankenship actually this wasn't intended to be merged yet...

[retrohacker]

Yeah, I thought that through as I hit merge. Will undo in a moment.

[rvagg]

How about this: original person initiating the PR should be responsible for merging it if they are a collaborator, they should also seek +1's from others but if they've left enough time (> 1 day) and not got any feedback then they can just go ahead. This is roughly in line with the iojs/io.js repo rules but a little more flexible to account for a smaller and more agile team.

[rvagg]

I read [this comment] as saying they were going to do their own thing anyway, has anyone got an update on this?

[pesho]

@wblankenship thanks for reverting.

@rvagg, +1 on this policy. What about making trivial/non-controversial patches directly, without a PR?

[rvagg]

PRs increase visibility even for minor changes. The policy I've adopted in iojs/build for trivial patches is just a quick PR and immediate merge with an explanation of why I didn't wait for feedback.

[pesho]

Ok, sounds fine to me.

I read [this comment] as saying they were going to do their own thing anyway, has anyone got an update on this?

Not sure which comment you are referring to.

[rvagg]

heh, derp, that would be this comment

[pesho]

Yes, I see how it may sound so, but in this case I think it's a misunderstanding. @jfrazelle only opened an issue asking for an official iojs image, and this is exactly what we are preparing in this repo.

The way official images are built is different than normal ones. They are built by a set of scripts called stackbrew/bashbrew from officially designated repositories (this repository will be the official iojs one). These scripts are more flexible than the publicly accessible Docker Hub Automated Build, which is rather limited (for example, it doesn't let us specify that the -onbuild image depends on and should be built after the default image, which can mess up the builds). The source for the official image will still be in this repository, docker-library/official-images will just contain links to it, and to specific tags in it (which we will have to update via PRs).

[jessfraz]

Yes, when you all are ready you can create a PR to the official-images repo
with links to your repo. So sorry if I caused any misunderstanding I will
close the other issue :)
I also should say I think this repo looks really good I may play around
with a few things, and make a PR if I find any enhancements but over all
this looks great.

On Sunday, January 18, 2015, Peter Petrov [email protected] wrote:

Yes, I see how it may sound so, but in this case I think it's a
misunderstanding. @jfrazelle https://github.com/jfrazelle only opened
an issue asking for an official iojs image, and this is exactly what we are
preparing in this repo.

The way official images are built is different than normal ones. They are
built by a set of scripts called stackbrew/bashbrew from officially
designated repositories (this repository will be the official iojs one).
These scripts are more flexible than the publicly accessible Docker Hub
Automated Build, which is rather limited (for example, it doesn't let us
specify that the -onbuild image depends on and should be built after the
default image, which can mess up the builds). The source for the official
image will still be in this repository, docker-library/official-images
will just contain links to it, and to specifig tags in it (which we will
have to update via PRs).

—
Reply to this email directly or view it on GitHub
#7 (comment).

Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

[pesho]

Thanks @jfrazelle :) The PRs have just been sent.