Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official io.js Docker image #446

Closed
pesho opened this issue Jan 15, 2015 · 16 comments
Closed

Official io.js Docker image #446

pesho opened this issue Jan 15, 2015 · 16 comments

Comments

@pesho
Copy link
Contributor

pesho commented Jan 15, 2015

I've adapted the official Node.js 11.x Docker image for io.js:

Source (GitHub): https://github.com/pesho/docker-iojs
Docker registry repo: https://registry.hub.docker.com/u/onestone/iojs/

I've also contacted Docker Inc regarding possibly promoting this to their "Official Repos" program. If the core io.js team approves this (which would mean adopting the code under the iojs GitHub org), it can be done. I'm up for participating in future maintenance of the image, but will need co-maintainers.

@pesho
Copy link
Contributor Author

pesho commented Jan 15, 2015

cc @rvagg @wblankenship

@reggi
Copy link
Contributor

reggi commented Jan 15, 2015

This is pretty helpful! Thanks @pesho 👍

@rvagg
Copy link
Member

rvagg commented Jan 16, 2015

@pesho were you the one I was discussing this with on IRC? Sorry, poor memory on my end.

@pesho
Copy link
Contributor Author

pesho commented Jan 16, 2015

@rvagg regarding the PGP key? Yes :) (my nick on IRC was onestone)

@rvagg
Copy link
Member

rvagg commented Jan 16, 2015

excellent! yes, I'd like to hear from @wblankenship and @ghostbar with their thoughts on your images, if they're happy then we should probably add you to the build team and figure out how best to manage these under the iojs org

@retrohacker
Copy link

<:heart:>
Everything checks out 😄

Great work on these, I say they would be great to get into the org repos!
</:heart:>

@pesho
Copy link
Contributor Author

pesho commented Jan 16, 2015

Great to hear!

How should the move be performed? It requires someone with iojs admin rights, maybe I can add an iojs admin as a repo collaborator?

@rvagg
Copy link
Member

rvagg commented Jan 16, 2015

👍 let me create a repo here, populate it with your git data .. just getting a release out right now so might defer this for a little while

@rvagg
Copy link
Member

rvagg commented Jan 16, 2015

@pesho do you have a Docker Hub account, if so, what's your username?

created iojs/docker-iojs repo, @wblankenship is sorting it out now and hooking up to Docker Hub. I'll add you to the iojs build team on GH.

@retrohacker
Copy link

@pesho
Copy link
Contributor Author

pesho commented Jan 16, 2015

Excellent 👍

@rvagg my Docker Hub username is onestone

@rvagg
Copy link
Member

rvagg commented Jan 16, 2015

done, you're now on the iojs org on Docker Hub and in the iojs/build team on GitHub, @wblankenship has done initial work on moving your images over and has some change suggestions but will submit them for discussion via pull request to that repo.

@rvagg rvagg closed this as completed Jan 16, 2015
@rvagg
Copy link
Member

rvagg commented Jan 16, 2015

Thanks all! This is great!

@cecilemuller
Copy link

Sweet, that will come in handy 👍

@jessfraz
Copy link

I have opened an issue for an official iojs image at docker-library/official-images#408. But I didn't realize you all had already made one, this however would live under the library namespace and support things like FROM iojs and docker run -it iojs, etc etc. Feel free to comment either way.
I'm also HTH in anyway, if you want to make the image more minimal, or decide you want to add it to the official images :)

@retrohacker
Copy link

Rock on @jfrazelle, we are working on slimming down both of the images (1.0 and 1.0-slim). If you have any recommendations, would love your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants