Skip to content
This repository has been archived by the owner on Jul 20, 2018. It is now read-only.

Prepare for image becoming official (change links, image id, etc.) #8

Merged
merged 2 commits into from
Jan 19, 2015

Conversation

retrohacker
Copy link
Contributor

Fixing preemptive merge from #7

@retrohacker
Copy link
Contributor Author

Is it safe to merge this now that docker-library/official-images#409 is closed and https://registry.hub.docker.com/_/iojs/ is live? Or would we like to let #9 play out first?

@pesho
Copy link
Contributor

pesho commented Jan 19, 2015

I think we should wait for docker-library/docs#141 to be merged as well. /cc @tianon @yosifkit

#9 can wait IMO, let's gather more opinions and not rush it.

@tianon
Copy link
Contributor

tianon commented Jan 19, 2015

Since this isn't about the docs and is the source of the image itself,
wouldn't it make sense to merge this now? You've officially got /_/iojs,
and now we're just working on the docs which are out-of-band, so I'm not
sure there's a reason to hold this up based on the docs PR, right?

pesho added a commit that referenced this pull request Jan 19, 2015
Prepare for image becoming official (change links, image id, etc.)
@pesho pesho merged commit 0b11ef3 into master Jan 19, 2015
@pesho
Copy link
Contributor

pesho commented Jan 19, 2015

Ok, merged.

@pesho pesho deleted the prepare_official2 branch January 19, 2015 23:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants