Skip to content

wayfire: mixup between wayfire and wf-shell settings#1670

Merged
trueNAHO merged 1 commit intonix-community:masterfrom
einetuer:fix-wayfire-option-mixup
Jul 11, 2025
Merged

wayfire: mixup between wayfire and wf-shell settings#1670
trueNAHO merged 1 commit intonix-community:masterfrom
einetuer:fix-wayfire-option-mixup

Conversation

@einetuer
Copy link
Copy Markdown
Contributor

@einetuer einetuer commented Jul 10, 2025

It appears that while migrating to mkTarget some of the options to wayfire itself have become mixed up into the wf-shell ones.

While at it, I've implemented #1658, because I feel like that would have been a merge conflict.

Superceeds/Closes Might conflict with #1658

Things done

Notify maintainers

@stylix-automation stylix-automation bot added the topic: home-manager Home Manager target label Jul 10, 2025
@einetuer einetuer force-pushed the fix-wayfire-option-mixup branch from 2f5ff37 to 48812c0 Compare July 10, 2025 21:45
Copy link
Copy Markdown
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@trueNAHO trueNAHO merged commit 0150050 into nix-community:master Jul 11, 2025
7 checks passed
stylix-automation bot pushed a commit that referenced this pull request Jul 11, 2025
Fixes: aa5e3c0 ("treewide: use mkTarget (batch 3) (#1371)")
Link: #1670

Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
(cherry picked from commit 0150050)
@stylix-automation
Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-25.05:

trueNAHO pushed a commit that referenced this pull request Jul 11, 2025
Fixes: aa5e3c0 ("treewide: use mkTarget (batch 3) (#1371)")
Link: #1670

Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
(cherry picked from commit 0150050)
LunaCOLON3 pushed a commit to LunaCOLON3/stylix that referenced this pull request Jul 14, 2025
)

Fixes: aa5e3c0 ("treewide: use mkTarget (batch 3) (nix-community#1371)")
Link: nix-community#1670

Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: home-manager Home Manager target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants