treewide: use mkTarget (batch 3)

[0xda157]

Things done

• Tested locally
• Tested in testbed
• Commit message follows commit convention
• Fits style guide
• Respects license of any existing code used

Notify maintainers

[0xda157]

@MattSturgeon could you take a look?

error: infinite recursion encountered

[Flameopathic]

The infinite recursion here seems to be coming from setting config.lib.stylix, and it may be because setting it is based on an option in config.lib.stylix (colors). I'm not sure what could be done here.

[MattSturgeon]

@MattSturgeon could you take a look?

error: infinite recursion encountered

I'll try to have a look a bit later

[0xda157]

The infinite recursion here seems to be coming from setting config.lib.stylix, and it may be because setting it is based on an option in config.lib.stylix (colors). I'm not sure what could be done here.

It's a fundamental issue of having the config.lib.stylix.i3.bar, I'll drop i3 from this pr and look into fixing it in a separate pr.

[MattSturgeon]

The infinite recursion here seems to be coming from setting config.lib.stylix, and it may be because setting it is based on an option in config.lib.stylix (colors). I'm not sure what could be done here.

It's a fundamental issue of having the config.lib.stylix.i3.bar, I'll drop i3 from this pr and look into fixing it in a separate pr.

 configElements = [
  (
    { fonts }:
    {
      xsession.windowManager.i3.config.fonts = {
        names = [ fonts.sansSerif.name ];
        size = fonts.size.desktop * 1.0;
      };
      lib.stylix.i3.bar.fonts = {
        names = [ fonts.sansSerif.name ];
        size = fonts.size.desktop * 1.0;
      };
    }
  )
]

I believe what makes this inf-rec (and why it wasn't before) is the fact that whether or not lib.stylix.i3.bar.fonts.{name,size} are defined is now predicated on whether lib.stylix.fonts is non-null.

Nix should be able to support that kinda recursion, because lib.stylix.i3 should be able to depend on lib.stylix.fonts lazily, however sometimes module-system types introduce additional strictness (i.e., the opposite of laziness).

In this case config.lib is type lib.types.attrs, which like lib.types.attrsOf may be strict. IIRC this is the reason lib.types.lazyAttrsOf exists, however that has its own pitfalls.

---

Caveat: this is just based on reading the diff and your comments, so I may be slightly off.

Also: sorry I wasn't around to help identify the issue! Well done figuring it out.

[trueNAHO]

The infinite recursion here seems to be coming from setting config.lib.stylix, and it may be because setting it is based on an option in config.lib.stylix (colors). I'm not sure what could be done here.

It's a fundamental issue of having the config.lib.stylix.i3.bar, I'll drop i3 from this pr and look into fixing it in a separate pr.

 configElements = [
  (
    { fonts }:
    {
      xsession.windowManager.i3.config.fonts = {
        names = [ fonts.sansSerif.name ];
        size = fonts.size.desktop * 1.0;
      };
      lib.stylix.i3.bar.fonts = {
        names = [ fonts.sansSerif.name ];
        size = fonts.size.desktop * 1.0;
      };
    }
  )
]

I believe what makes this inf-rec (and why it wasn't before) is the fact that whether or not lib.stylix.i3.bar.fonts.{name,size} are defined is now predicated on whether lib.stylix.fonts is non-null.

Nix should be able to support that kinda recursion, because lib.stylix.i3 should be able to depend on lib.stylix.fonts lazily, however sometimes module-system types introduce additional strictness (i.e., the opposite of laziness).

In this case config.lib is type lib.types.attrs, which like lib.types.attrsOf may be strict. IIRC this is the reason lib.types.lazyAttrsOf exists, however that has its own pitfalls.

Thanks for the great explanations. As always.

There have been brief discussions in the past of migrating these interfaces into readOnly options to prevent them from being undocumented outside of the brief source code comment and because it makes the code nicer.

For reference, here are the relevant rg '# Merge this with' matches:

• stylix/modules/i3/hm.nix

  Lines 67 to 68 in b69e9b7

  	# Merge this with your bar configuration using //config.lib.stylix.i3.bar
  	lib.stylix.i3.bar = {

• stylix/modules/i3status-rust/hm.nix

  Lines 3 to 4 in b69e9b7

  	# Merge this with your bar's theme's overrides with //config.lib.stylix.i3status-rust.bar
  	config.lib.stylix.i3status-rust.bar =

• stylix/modules/sway/hm.nix

  Lines 72 to 73 in b69e9b7

  	# Merge this with your bar configuration using //config.lib.stylix.sway.bar
  	lib.stylix.sway.bar = {

It is possible that this pattern is used elsewhere without this comment.

[trueNAHO]

LGTM, except for one detail.

[trueNAHO]

LGTM.

[stylix-automation]

Successfully created backport PR for release-25.05:

• [release-25.05] treewide: use mkTarget (batch 3) #1448