wayfire: remove optional toString

[trueNAHO]

This PR should not be merged untested.

Things done

• Tested locally
• Tested in testbed
• Commit message follows commit convention
• Fits style guide
• Respects license of any existing code used

Notify maintainers

@0x5a4

[trueNAHO]

This PR should not be merged untested.

If the current approach does not work, the toString conversion could be centralized as:

diff --git a/modules/wayfire/hm.nix b/modules/wayfire/hm.nix
index d11ad25..7b8b814 100644
--- a/modules/wayfire/hm.nix
+++ b/modules/wayfire/hm.nix
@@ -26,9 +26,11 @@ mkTarget {
         imageScalingMode,
       }:
       let
-        wayfireBackground = pkgs.runCommand "wayfire-background.png" { } ''
-          ${lib.getExe' pkgs.imagemagick "convert"} ${image} $out
-        '';
+        wayfireBackground = toString (
+          pkgs.runCommand "wayfire-background.png" { } ''
+            ${lib.getExe' pkgs.imagemagick "convert"} ${image} $out
+          ''
+        );
       in
       {
         wayland.windowManager.wayfire.wf-shell.settings = {

[einetuer]

What about this might not work? Straight eval failure?

EDIT: yes.

[einetuer]

Tested, and the toString call is required (the home-manager type is too restrictive, my bad).

EDIT: Created nix-community/home-manager#7427 to address this. If merged, I will create a follow up PR here to get rid of toString once and for all

[trueNAHO]

Created nix-community/home-manager#7427 to address this. If merged, I will create a follow up PR here to get rid of toString once and for all

Thanks :)

If the only additional change is updating the Home Manager input, I can also do it in this PR. I leave it up to you. Either way, I am converting this PR to a draft until nix-community/home-manager#7427 is merged.

[einetuer]

The home-manager PR was merged, you can also make the update here. I'll test it again then

[trueNAHO]

The home-manager PR was merged, you can also make the update here. I'll test it again then

I have updated the home-manager input. Could you test this PR again?

[einetuer]

Works!

[stylix-automation]

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-1658-to-release-25.05 origin/release-25.05
cd .worktree/backport-1658-to-release-25.05
git switch --create backport-1658-to-release-25.05
git cherry-pick -x a950a3f529e1952a7ddf2af138b90a99edf41fe5

[trueNAHO]

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-1658-to-release-25.05 origin/release-25.05
cd .worktree/backport-1658-to-release-25.05
git switch --create backport-1658-to-release-25.05
git cherry-pick -x a950a3f529e1952a7ddf2af138b90a99edf41fe5

The nix-community/home-manager#7427 PR has not been backported to the stable branch yet. Since this is a fairly low priority change, we can just not backport this for the time being.