Skip to content

wayfire: allow path in settings#7427

Merged
khaneliman merged 1 commit intonix-community:masterfrom
einetuer:wayfire-allow-path-in-store
Jul 11, 2025
Merged

wayfire: allow path in settings#7427
khaneliman merged 1 commit intonix-community:masterfrom
einetuer:wayfire-allow-path-in-store

Conversation

@einetuer
Copy link
Copy Markdown
Contributor

Description

Allow a store path to be specified in wayfire's settings. Not strictly necessary, but having to call toString when setting wallpaper, cubemap background etc gets pretty annoying and feels unnecessary.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt-rfc-style deadnix keep-sorted --run treefmt.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

Comment thread modules/services/window-managers/wayfire.nix Outdated
@einetuer einetuer force-pushed the wayfire-allow-path-in-store branch from 60207e0 to 607ccb2 Compare July 11, 2025 08:34
@einetuer einetuer changed the title wayfire: allow pathInStore in settings wayfire: allow path in settings Jul 11, 2025
@einetuer einetuer requested a review from khaneliman July 11, 2025 08:35
Copy link
Copy Markdown
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@khaneliman khaneliman merged commit e90b289 into nix-community:master Jul 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

window-managers sway, gnome, i3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants