Skip to content

wayfire: remove illegal config.stylix access#1609

Merged
0xda157 merged 1 commit intonix-community:masterfrom
Flameopathic:wayfire-illegal-access
Jul 6, 2025
Merged

wayfire: remove illegal config.stylix access#1609
0xda157 merged 1 commit intonix-community:masterfrom
Flameopathic:wayfire-illegal-access

Conversation

@Flameopathic
Copy link
Copy Markdown
Contributor

@Flameopathic Flameopathic commented Jul 6, 2025

Fixes #1607

@fierce-goose would you test to see if this PR fixes your issue?

Things done

Notify maintainers

@0x5a4

@stylix-automation stylix-automation bot added the topic: home-manager Home Manager target label Jul 6, 2025
0xda157
0xda157 approved these changes Jul 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@0xda157 0xda157 merged commit 5cd1e4f into nix-community:master Jul 6, 2025
6 checks passed
@stylix-automation
Copy link
Copy Markdown
Contributor

stylix-automation bot commented Jul 6, 2025

Successfully created backport PR for release-25.05:

stylix-automation bot pushed a commit that referenced this pull request Jul 6, 2025
@Flameopathic @github-actions
wayfire: remove illegal config.stylix access (#1609)
80a9ca6 
Link: #1609
Fixes: aa5e3c0 ("treewide: use mkTarget (batch 3) (#1371)")

Reviewed-by: awwpotato <awwpotato@voidq.com>
(cherry picked from commit 5cd1e4f)
@stylix-automation stylix-automation bot mentioned this pull request Jul 6, 2025
Merged
@trueNAHO
Copy link
Copy Markdown
Member

trueNAHO commented Jul 6, 2025 •
edited
Loading

Great to see commit dea0337 ("stylix: restrict access to config while using mkTarget (#1368)") catching improvements.

0xda157 pushed a commit that referenced this pull request Jul 6, 2025
@Flameopathic @0xda157
wayfire: remove illegal config.stylix access (#1609)
8a4eec8 
Link: #1609
Fixes: aa5e3c0 ("treewide: use mkTarget (batch 3) (#1371)")

Reviewed-by: awwpotato <awwpotato@voidq.com>
(cherry picked from commit 5cd1e4f)
@fierce-goose
Copy link
Copy Markdown

fierce-goose commented Jul 6, 2025

yes, now it works, thanks

LunaCOLON3 pushed a commit to LunaCOLON3/stylix that referenced this pull request Jul 14, 2025
@Flameopathic @LunaCOLON3
wayfire: remove illegal config.stylix access (nix-community#1609)
92fab53 
Link: nix-community#1609
Fixes: aa5e3c0 ("treewide: use mkTarget (batch 3) (nix-community#1371)")

Reviewed-by: awwpotato <awwpotato@voidq.com>
@Flameopathic Flameopathic deleted the wayfire-illegal-access branch September 24, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xda157 0xda157 0xda157 approved these changes

Assignees

No one assigned

Labels

topic: home-manager Home Manager target

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wayfire: error when rebuilding: unguareded config.stylix accessed while using mkTarget

4 participants

@Flameopathic @trueNAHO @fierce-goose @0xda157