Skip to content

doc: restructure module rendering#1083

Merged
danth merged 1 commit intonix-community:masterfrom
Flameopathic:homepages
May 18, 2025
Merged

doc: restructure module rendering#1083
danth merged 1 commit intonix-community:masterfrom
Flameopathic:homepages

Conversation

@Flameopathic
Copy link
Copy Markdown
Contributor

@Flameopathic Flameopathic commented Apr 2, 2025

changes:

  • changes rendering order and style of module documentation elements
  • adds meta.homepage
  • adds meta.description
  • removes existing README.md files
  • documents added meta attributes

related: #883

Things done

@0xda157
Copy link
Copy Markdown
Contributor

0xda157 commented Apr 2, 2025

shouldn't we just have a package meta attribute and get the homepage from the meta of the package?

@Flameopathic
Copy link
Copy Markdown
Contributor Author

shouldn't we just have a package meta attribute and get the homepage from the meta of the package?

we could, though this wouldn't work for targets without packages like Nixvim for example

@0xda157
Copy link
Copy Markdown
Contributor

0xda157 commented Apr 2, 2025

though this wouldn't work for targets without packages like Nixvim for example

we can have package be null or derivation and homepage be null or string and have homepage default to package.meta.homepage.

@Flameopathic
Copy link
Copy Markdown
Contributor Author

we can have package be null or derivation and homepage be null or string and have homepage default to package.meta.homepage.

that would work, though i'm not sure how to implement defaults in this context.

@0xda157
Copy link
Copy Markdown
Contributor

0xda157 commented Apr 2, 2025

that would work, though i'm not sure how to implement defaults in this context.

something like meta.homepage or meta.package.meta.homepage

@Flameopathic Flameopathic force-pushed the homepages branch 3 times, most recently from daba2d8 to 0eeb7d7 Compare April 2, 2025 20:18
@Flameopathic
Copy link
Copy Markdown
Contributor Author

i am satisfied with how this should function, but i am not sure how to test how this is going to render.

@0xda157 0xda157 requested a review from danth April 2, 2025 21:45
@Flameopathic
Copy link
Copy Markdown
Contributor Author

Flameopathic commented Apr 2, 2025

one side effect of the way that this will render the hyperlink is that all link text is lowercase because most of it comes from the package names.

in addition, the most recent commit changes nearly every meta.nix file. this may make merging with treewide-init-maintainers more difficult.

@Flameopathic Flameopathic force-pushed the homepages branch 5 times, most recently from 620a8b5 to c7ed824 Compare April 3, 2025 14:28
@Flameopathic
Copy link
Copy Markdown
Contributor Author

Flameopathic commented Apr 3, 2025

using packages to get homepages is posing an issue on Darwin. i believe it is because some packages aren't available for Darwin. i have disabled the docs check on Darwin because i can't think of how to properly fix this, but this is probably not a good way to move forward. help would be appreciated.

@danth
Copy link
Copy Markdown
Member

danth commented Apr 13, 2025

i am not sure how to test how this is going to render

nix build .#docs && xdg-open ./result/index.html

@Flameopathic Flameopathic force-pushed the homepages branch 9 times, most recently from 5b44642 to ee84baf Compare April 15, 2025 00:12
Copy link
Copy Markdown
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good 👍

@Flameopathic Flameopathic force-pushed the homepages branch 3 times, most recently from 3e08ad8 to 848fb2c Compare May 7, 2025 22:07
@danth
Copy link
Copy Markdown
Member

danth commented May 9, 2025

I discovered in #1212 that the font options accidentally include the actual packages in the docs instead of literalExpressions, so I opened #1225 to fix that

Note that this fix has been merged :))

@0xda157 0xda157 mentioned this pull request May 11, 2025
5 tasks
@Flameopathic
Copy link
Copy Markdown
Contributor Author

I discovered in #1212 that the font options accidentally include the actual packages in the docs instead of literalExpressions, so I opened #1225 to fix that

Note that this fix has been merged :))

I would rather save it for another PR with how much this one does.

@stylix-automation stylix-automation bot added the topic: documentation Documentation additions or improvements label May 11, 2025
- changes rendering order and style of module documentation elements
- adds `meta.homepage`
- adds `meta.description`
- removes existing `README.md` files
- documents added `meta` attributes
Copy link
Copy Markdown
Member

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you :))

@danth danth merged commit e2fe2df into nix-community:master May 18, 2025
5 checks passed
MattSturgeon added a commit to MattSturgeon/stylix that referenced this pull request May 21, 2025
Remove references to `modules/«module»/README.md`, as this was replaced
by `modules/«module»/meta.nix`.
MrSom3body pushed a commit to MrSom3body-contrib/stylix that referenced this pull request May 22, 2025
0xda157 pushed a commit that referenced this pull request May 25, 2025
Link: #1329

Reviewed-by: awwpotato <awwpotato@voidq.com>
Reviewed-by: Flameopathic <64027365+Flameopathic@users.noreply.github.com>
stylix-automation bot pushed a commit that referenced this pull request May 25, 2025
Link: #1329

Reviewed-by: awwpotato <awwpotato@voidq.com>
Reviewed-by: Flameopathic <64027365+Flameopathic@users.noreply.github.com>
(cherry picked from commit e22f96d)
0xda157 pushed a commit that referenced this pull request May 25, 2025
Link: #1329

Reviewed-by: awwpotato <awwpotato@voidq.com>
Reviewed-by: Flameopathic <64027365+Flameopathic@users.noreply.github.com>
(cherry picked from commit e22f96d)
@Flameopathic Flameopathic deleted the homepages branch June 13, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: documentation Documentation additions or improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants