stylix: simplify font options & use literalExpression default packages#1225
Merged
danth merged 2 commits intonix-community:masterfrom May 9, 2025
Merged
stylix: simplify font options & use literalExpression default packages#1225danth merged 2 commits intonix-community:masterfrom
literalExpression default packages#1225danth merged 2 commits intonix-community:masterfrom
Conversation
MattSturgeon
force-pushed
the
font/defaultText
branch
from
223134b to
6a4ac17
Compare
MattSturgeon
changed the title
literalExpression for font package defaultsliteralExpression default packages
This was referenced May 4, 2025
MattSturgeon
commented
May 6, 2025
Derivation values shouldn't be rendered in option docs. Instead a `literalExpression` or `literalMD` should describe the default/example. Usually, `lib.mkPackageOption` is convenient, however in this case the option is a little more complex.
MattSturgeon
force-pushed
the
font/defaultText
branch
from
fb1c068 to
66cb39c
Compare
MrSom3body
pushed a commit
to MrSom3body-contrib/stylix
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derivation values shouldn't be rendered in option docs. Instead a
literalExpressionorliteralMDshould describe the default/example.This PR was cherry-picked from #1212 in an effort to make that PR smaller and easier to review, while also making these changes easier to focus on in a dedicated PR.
I've gone a step further than the minimal fix originally proposed in #1212, as I believe the options can be simplified a little:
nameandpackage)lib.mkPackageOptioninstead of implementingdefaultTextit by hand.I believe this also results in simpler documentation, with two entries per font instead of three:
Screenshot
Things done
Notify maintainers
@dwarfmaster