Skip to content

wayprompt: init#1250

Merged
0xda157 merged 17 commits intonix-community:masterfrom
nukdokplex:master
May 11, 2025
Merged

wayprompt: init#1250
0xda157 merged 17 commits intonix-community:masterfrom
nukdokplex:master

Conversation

@nukdokplex
Copy link
Copy Markdown
Contributor

@nukdokplex nukdokplex commented May 10, 2025

Things done

Added wayprompt target because it became available in home manager

Notify maintainers

it's me :)

Copy link
Copy Markdown
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also you should add a testbed

@0xda157
Copy link
Copy Markdown
Contributor

0xda157 commented May 11, 2025

you also need to update home manager (nix flake update home-manager)

@nukdokplex
Copy link
Copy Markdown
Contributor Author

also you should add a testbed

i didn't create any before, but i can try :)

@nukdokplex
Copy link
Copy Markdown
Contributor Author

nukdokplex commented May 11, 2025

@awwpotato wayprompt can't run in default testbed for some reason
image
upd: will try to make a sway environment

@nukdokplex nukdokplex requested a review from 0xda157 May 11, 2025 02:33
@nukdokplex
Copy link
Copy Markdown
Contributor Author

maybe buttons' borders should be colored same as buttons' bg, i think it looks better

before
image

after
image

@nukdokplex nukdokplex requested a review from 0xda157 May 11, 2025 15:20
@nukdokplex
Copy link
Copy Markdown
Contributor Author

nukdokplex commented May 11, 2025

@awwpotato any blockers remaining? except of this one #1250 (comment)

@stylix-automation stylix-automation bot added topic: dependencies Dependency updates topic: home-manager Home Manager target labels May 11, 2025
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@nukdokplex nukdokplex requested a review from 0xda157 May 11, 2025 22:42
@0xda157 0xda157 enabled auto-merge (squash) May 11, 2025 22:56
@0xda157 0xda157 merged commit 6b83095 into nix-community:master May 11, 2025
5 checks passed
@panchoh panchoh mentioned this pull request May 12, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: dependencies Dependency updates topic: home-manager Home Manager target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants