vicinae service: init#8093
Conversation
|
@schromp I'm tagging you so you are aware. |
khaneliman
left a comment
khaneliman
left a comment
There was a problem hiding this comment.
Just some stuff to follow our latest patterns.
|
Thanks for the review @khaneliman |
|
Given that auto-starting is optional, should I move this to programs instead of services ? |
leiserfg
force-pushed
the
push-louqkyuwrmtp
branch
from
dcbdfd0 to
cc83703
Compare
Yeah probably could make more sense that way |
|
Could you add some basic tests and a news entry, please. |
|
I had to bump nixpkgs as the one that home-manager had, didn't include vicinae. |
leiserfg
force-pushed
the
push-louqkyuwrmtp
branch
2 times, most recently
from
dbe872a to
941cca6
Compare
| @@ -54,7 +54,7 @@ | |||
|
|
|||
| ''} | |||
| assertFileContent $lightModeScriptFile ${builtins.toFile "expected" '' | |||
| #!@python@/bin/python | |||
| #!@python3@/bin/python | |||
There was a problem hiding this comment.
These are unrelated changes. Could you remove them
There was a problem hiding this comment.
Sure, I did it in order to make the tests pass after updating nixpkgs, I just fixed this one in a different manner to master 😄
leiserfg
force-pushed
the
push-louqkyuwrmtp
branch
from
941cca6 to
48d9ca9
Compare
khaneliman
left a comment
khaneliman
left a comment
There was a problem hiding this comment.
sorry, just realized this was also generating json and should also use the generator
Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
khaneliman
force-pushed
the
push-louqkyuwrmtp
branch
from
10e5fc6 to
e3d31cc
Compare
| Documentation = [ "https://docs.vicinae.com" ]; | ||
| After = [ cfg.systemd.target ]; | ||
| PartOf = [ cfg.systemd.target ]; | ||
| BindsTo = [ cfg.systemd.target ]; |
There was a problem hiding this comment.
I don't think this unit should have used BindsTo as it blocks logout (at least for plasma) when vicinae service is running.
There was a problem hiding this comment.
Are you sure that is it? BindsTo is a direct relationship not a reverse one.
There was a problem hiding this comment.
Pretty sure - This fixed logout for me https://github.com/marcusramberg/nix-config/blob/main/home/plasma/default.nix#L375
There was a problem hiding this comment.
I also had the same problem with cloudflare warp NixOS/nixpkgs#434733
There was a problem hiding this comment.
Ok, I'll make a PR.
3 participants
Description
Adds service for vecinae.
The code is mostly verbatim from https://github.com/vicinaehq/vicinae/blob/main/nix/vicinae.nix
with the main difference that I moved the logic for packaging extensions into the module itself.
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.