vicinae: support Home Manager module alongside upstream module#2068
vicinae: support Home Manager module alongside upstream module#2068trueNAHO merged 8 commits intonix-community:masterfrom
Conversation
b6cf684 to
34ea4a0
Compare
0xda157
left a comment
There was a problem hiding this comment.
a testbed for the home-manager options should be added
|
Applied all suggested improvements, awaiting a review :) |
|
I've been looking at other examples to better understand how stylix works. And looks like there is no need to check for presence of So maybe, a final implementation for eachConfig =
config:
let
finalConfig = {
vicinae = config;
};
in
{
services = lib.optionalAttrs (options.services ? vicinae) finalConfig;
programs = finalConfig;
};What do you think? |
|
this should be merged after nix-community/home-manager#8313 is merged (if it isn't rejected). |
|
I'd be fine with merging this as, because it seems that nix-community/home-manager#8313 isn't likely to be merged soon.
that would break compatibility with older home-manager version, but that is fine as stylix only supports the most recent hm commit (on unstable). |
trueNAHO
left a comment
There was a problem hiding this comment.
I'd be fine with merging this as, because it seems that nix-community/home-manager#8313 isn't likely to be merged soon.
Yes, this PR LGTM.
@rwxae, could you resolve the merge conflicts?
|
@trueNAHO, fine, I'll do it! |
|
I am so bad at git |
38adba0 to
0d2fa16
Compare
Implied approval by the following statement:
I'd be fine with merging this as, because it seems that nix-community/home-manager#8313 isn't likely to be merged soon.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.11
git worktree add -d .worktree/backport-2068-to-release-25.11 origin/release-25.11
cd .worktree/backport-2068-to-release-25.11
git switch --create backport-2068-to-release-25.11
git cherry-pick -x a4406d9799d002c41296c72378a1094a8fc9aa1b |
…ommunity#2068) Support the Home Manager module via programs.vicinae alongside the upstream module's services.vicinae namespace. Unifying both modules is continued in [1] ("vicinae: move from programs to services"). [1]: nix-community/home-manager#8313 Closes: nix-community#2076 Link: nix-community#2068 Reviewed-by: 0xda157 <da157@voidq.com> Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com> (cherry picked from commit a4406d9)
…ommunity#2068) Support the Home Manager module via programs.vicinae alongside the upstream module's services.vicinae namespace. Unifying both modules is continued in [1] ("vicinae: move from programs to services"). [1]: nix-community/home-manager#8313 Closes: nix-community#2076 Link: nix-community#2068 Reviewed-by: 0xda157 <da157@voidq.com> Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com> (cherry picked from commit a4406d9)
…ommunity#2068) Support the Home Manager module via programs.vicinae alongside the upstream module's services.vicinae namespace. Unifying both modules is continued in [1] ("vicinae: move from programs to services"). [1]: nix-community/home-manager#8313 Closes: nix-community#2076 Link: nix-community#2068 Reviewed-by: 0xda157 <da157@voidq.com> Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com> (cherry picked from commit a4406d9)
…ommunity#2068) Support the Home Manager module via programs.vicinae alongside the upstream module's services.vicinae namespace. Unifying both modules is continued in [1] ("vicinae: move from programs to services"). [1]: nix-community/home-manager#8313 Closes: nix-community#2076 Link: nix-community#2068 Reviewed-by: 0xda157 <da157@voidq.com> Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com> (cherry picked from commit a4406d9)
Support the Home Manager module via programs.vicinae alongside the
upstream module's services.vicinae namespace.
Unifying both modules is continued in [1] ("vicinae: move from programs
to services").
[1]: nix-community/home-manager#8313
Closes: #2076
Link: #2068
Reviewed-by: 0xda157 <da157@voidq.com>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
(cherry picked from commit a4406d9)
Description
Adds support for official home-manager options for vicinae (configured via
programs.vicinaeinstead ofservices.vicinae).Official options for vicinae in home-manager were added in nix-community/home-manager#8093.
As stated by the author, these options should work the same way:
This is not a breaking change, users of the options that come from vicinae flake don't lose anything.
I'm welcome to hear any feedback.
Thank you for this amazing tool!
Closes: #2076