Skip to content

cloudflare-warp: use PartOf instead of BindsTo for taskbar service to prevent logout problems#434733

Merged
stigtsp merged 1 commit intoNixOS:masterfrom
marcusramberg:marcus/warp_fix
Aug 22, 2025
Merged

cloudflare-warp: use PartOf instead of BindsTo for taskbar service to prevent logout problems#434733
stigtsp merged 1 commit intoNixOS:masterfrom
marcusramberg:marcus/warp_fix

Conversation

@marcusramberg
Copy link
Copy Markdown
Contributor

@marcusramberg marcusramberg commented Aug 18, 2025 •
edited
Loading

Solution taken from the comments of the aur package - https://aur.archlinux.org/packages/cloudflare-warp-bin
Also changes the replace to fix deprecation warnings.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 18, 2025
@marcusramberg marcusramberg mentioned this pull request Aug 18, 2025
Open
3 tasks
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 18, 2025
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Aug 20, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5781

@marcusramberg marcusramberg requested a review from stigtsp August 22, 2025 12:54
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 22, 2025
stigtsp
stigtsp approved these changes Aug 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stigtsp stigtsp merged commit 3f078e4 into NixOS:master Aug 22, 2025
32 of 34 checks passed
@stigtsp stigtsp deleted the marcus/warp_fix branch August 22, 2025 15:47
@marcusramberg marcusramberg mentioned this pull request Nov 6, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcusramberg @nixos-discourse @stigtsp