jujutsu: support darwin guidelines for config placement#5416
jujutsu: support darwin guidelines for config placement#5416rycee merged 1 commit intonix-community:masterfrom mrnossiom:fix/jujustu-support-darwin-config-dirs
Conversation
|
Could someone hint me on what's wrong with the test ? |
|
LGTM, but I'm not sure about the tests either... |
|
For the tests: I'm getting |
|
I just forgot to escape the space in |
|
@huwaireb Could you please rerun the tests with the latest commit? I don't know why, the CI gives cryptic errors. |
erm, wut? The CI seems to be giving out unrelated errors? External messages
|
|
MacOS CI seems to be broken for the past ~3-4 days? Due to swift-5.8. Found a mention to what could be the culprit: requires a nixpkgs fix. opened an home-manager issue, see #5550. |
|
the above has been fixed, and it should be available in the latest locked nixpkgs in master. i think if @mrnossiom merges/rebases master then the swift build failure shouldn't cause ci to fail |
Follow up to #5207, fixing jujutsu module on darwin targets.
|
Thanks! Squashed and merged to master now 🙂 |

Follow up to #5207, fixing jujutsu module on darwin targets.
Closes #5544 (duplicate)
Description
If the module is evaluated on a Darwin platform, place config in
Library/Application Supportinstead of unsupported XDG directory.If someone could test it on Darwin, it would be great (e.g. @bnjmnt4n) :
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
Maintainer CC
@shikanime