jujutsu: fix config file location on Darwin#5544
Closed
Aehmlo wants to merge 1 commit intonix-community:masterfrom
Closed
jujutsu: fix config file location on Darwin#5544Aehmlo wants to merge 1 commit intonix-community:masterfrom
Aehmlo wants to merge 1 commit intonix-community:masterfrom
Conversation
jj looks for its config file in ~/Library/Application Support/jj on Darwin. The previous module implementation unconditionally stored the configuration file in $XDG_CONFIG_HOME/jj. This revision now uses the correct location on Darwin.
|
Looks like a duplicate of #5416. |
Contributor
|
It seems to be, indeed. PR was blocked by obscure tests. Let me try to fix it right now with the info you provided. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
jjtool loads its configuration from a platform-dependent location. On Darwin, it looks in~/Library/Application Support/jj. This revision updates theprograms.jujutsumodule to serialize the generated configuration to the correct location.Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test system information:
Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
Maintainer CC
@shikanime