jujutsu: support darwin guidelines for config placement#5781
jujutsu: support darwin guidelines for config placement#5781jkachmar wants to merge 1 commit intonix-community:release-24.05from
Conversation
Follow up to nix-community#5207, fixing jujutsu module on darwin targets.
|
how does merging work for |
|
Thanks! Rebased to the 24.05 branch in 3288b74. |
|
I appreciate this change in the grand scheme of things. With jj ignoring XDG_CONFIG_HOME, this is definitely the right thing to do. But as I already had a workaround in place by setting JJ_CONFIG, this just broke my setup. It took me embarassingly long to find the cause (in part because I had forgotten about setting JJ_CONFIG). Personally, I would have preferred if this would not have been backported. If this had come with the next release with an accompanying entry in the release notes, that would probably have saved me a lot of time. (I hope I do not sound too cranky. It is getting late in UTC+0200.) |
|
@puppe Sorry about the wasted time! I think you have a good point about this being a breaking change and it shouldn't have made it into the stable branch. Maybe it still would have been valuable to bring into the stable branch but perhaps with a news entry conditioned on jujutsu being enabled, then you at least would be notified about the change. In any case, I will keep this in mind for the future. |
Description
backports changes from #5416 to the
release-24.05branch.Maintainer CC
@shikanime