xdg: add XDG_*_HOME variables to systemd.user.sessionVariables#2790
Merged
berbiche merged 1 commit intonix-community:masterfrom Mar 18, 2022
Merged
xdg: add XDG_*_HOME variables to systemd.user.sessionVariables#2790berbiche merged 1 commit intonix-community:masterfrom
XDG_*_HOME variables to systemd.user.sessionVariables#2790berbiche merged 1 commit intonix-community:masterfrom
Conversation
ncfavier
force-pushed
the
xdg-vars-systemd
branch
from
913b521 to
cc8d65b
Compare
berbiche
reviewed
Mar 13, 2022
| xdg.stateHome = mkDefault defaultStateHome; | ||
|
|
||
| home.sessionVariables = variables; | ||
| systemd.user.sessionVariables = mkIf pkgs.stdenv.isLinux variables; |
Member
There was a problem hiding this comment.
Suggested change
| systemd.user.sessionVariables = mkIf pkgs.stdenv.isLinux variables; | |
| systemd.user.sessionVariables = mkIf pkgs.stdenv.hostPlatform.isLinux variables; |
Isn't stdenv.isLinux an alias for stdenv.hostPlatform.isLinux?
IIRC there was a PR in HM that changed the former expression to the latter.
Member
Author
There was a problem hiding this comment.
I copied what I saw in modules/systemd.nix. Grepping for isLinux it seems about 50/50. I can't find that PR, I'd be curious what the motivation is; is the alias discouraged?
Member
Author
Member
Author
There was a problem hiding this comment.
I fixed it for this file.
Make sure those variables are set in systemd user services. This mirrors the situation for `XDG_*_DIRS` variables.
ncfavier
force-pushed
the
xdg-vars-systemd
branch
from
cc8d65b to
02616ae
Compare
jficz
pushed a commit
to jficz/home-manager
that referenced
this pull request
Apr 7, 2022
…ix-community#2790) Make sure those variables are set in systemd user services. This mirrors the situation for `XDG_*_DIRS` variables.
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
…ix-community#2790) Make sure those variables are set in systemd user services. This mirrors the situation for `XDG_*_DIRS` variables.
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
…ix-community#2790) Make sure those variables are set in systemd user services. This mirrors the situation for `XDG_*_DIRS` variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure those variables are set in systemd user services. This mirrors the situation for
XDG_*_DIRSvariables.cc @tadfisher #1797
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.