Skip to content

modules: pkgs.hostPlatform -> pkgs.stdenv.hostPlatform#2528

Merged
rycee merged 1 commit intonix-community:masterfrom
r-burns:toplevel-platform
Dec 3, 2021
Merged

modules: pkgs.hostPlatform -> pkgs.stdenv.hostPlatform#2528
rycee merged 1 commit intonix-community:masterfrom
r-burns:toplevel-platform

Conversation

@r-burns
Copy link
Copy Markdown
Contributor

@r-burns r-burns commented Dec 3, 2021

We are attempting to deprecate these top-level attrs in upstream nixpkgs.

See also bc0acda

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@r-burns r-burns requested a review from rycee as a code owner December 3, 2021 05:39
We are attempting to deprecate these top-level attributes in upstream
Nixpkgs.

See also bc0acda.
@rycee rycee force-pushed the toplevel-platform branch from 5739135 to 781d25b Compare December 3, 2021 22:38
@rycee rycee merged commit 781d25b into nix-community:master Dec 3, 2021
@rycee
Copy link
Copy Markdown
Member

rycee commented Dec 3, 2021

Thanks! Merged to master now.

@r-burns r-burns deleted the toplevel-platform branch December 3, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants