Skip to content

modules/modules.nix: pkgs.system -> pkgs.stdenv.hostPlatform.system#2419

Merged
sumnerevans merged 1 commit intonix-community:masterfrom
eadwu:master
Oct 29, 2021
Merged

modules/modules.nix: pkgs.system -> pkgs.stdenv.hostPlatform.system#2419
sumnerevans merged 1 commit intonix-community:masterfrom
eadwu:master

Conversation

@eadwu
Copy link
Copy Markdown
Contributor

@eadwu eadwu commented Oct 27, 2021

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@eadwu eadwu requested a review from rycee as a code owner October 27, 2021 22:29
@eadwu
Copy link
Copy Markdown
Contributor Author

eadwu commented Oct 27, 2021

NixOS/nixpkgs#142616

Should fix eval error.

Comment thread modules/modules.nix Outdated
@r-burns
Copy link
Copy Markdown
Contributor

r-burns commented Oct 28, 2021

Thanks for this - I'm quite the home-manager enjoyer myself but did not think to check for alias usage here.

Similar to this change, we want to alias the redundant pkgs.{build,host,target}Platform -> pkgs.stdenv.{build,host,target}Platform soon, and I see there is some usage here, so I'll be sure to open another PR for those before aliasing them in nixpkgs.

@berbiche
Copy link
Copy Markdown
Member

This will have to be rebased on #2421 for the powerline-go fix.

@eadwu
Copy link
Copy Markdown
Contributor Author

eadwu commented Oct 29, 2021

Rebased.

@sumnerevans sumnerevans merged commit bc0acda into nix-community:master Oct 29, 2021
peterhoeg pushed a commit to peterhoeg/home-manager that referenced this pull request Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants