treewide: remove toplevel system attr#142616
Merged
r-burns merged 8 commits intoNixOS:masterfrom Oct 27, 2021
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
roberth
approved these changes
Oct 24, 2021
Member
|
Good idea. Maybe there is a lot more things that can be dealt with this way. |
Note that targetPlatform was incorrect when cross-compiling, and should be hostPlatform
r-burns
force-pushed
the
toplevel-system
branch
from
51f5405 to
8b38a0e
Compare
Ericson2314
approved these changes
Oct 24, 2021
Member
|
@ofborg eval |
SuperSandro2000
approved these changes
Oct 26, 2021
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
please merge if ofborg is done
Contributor
Author
|
@ofborg eval |
Member
|
Ah, this issue is one we've come across in the past... There are too many statuses on one commit, which GH doesn't like. If you force-push (or add a new commit, or anything to that effect), that will fix it for real. |
This is an old compat definition for stdenv.hostPlatform.system
r-burns
force-pushed
the
toplevel-system
branch
from
8b38a0e to
4246d6c
Compare
Contributor
Author
|
Thank you, looks like that did the trick |
Merged
7 tasks
Member
|
This change broke home-manager. See above link for details. |
Contributor
|
maybe we should add some home-manager checks to ofborg? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is motivated by #27069, but intentionally avoids any of the sticky deprecation questions which have caused that issue to stall out. The alias is still going to be there for the foreseeable future - this PR just fixes the few remaining uses in nixpkgs, and guards it behind allowAliases so we don't have to worry about it reappearing.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)