-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown code blocks part 4 #20189
Markdown code blocks part 4 #20189
Conversation
No logic was added, just 8 more files have been migrated.
Something I've been meaning to ask. There was a regression in the parser which caused it to fail on things like:
Do you know if this has been fixed? |
@dom96 No, it's still there, I did not know/remember about that. |
yeah, if you could that would be brilliant, it means lots of forum posts aren't rendering :/ |
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
Fixes bug reported in nim-lang#20189 affecting nimforum.
Fixes bug reported in nim-lang#20189 affecting nimforum. (manually backported version to 1.6 from devel)
* Improve error message for `strutils.addf` (#20157) Co-authored-by: ringabout <[email protected]> * fixes #20153; do not escape `_` for mysql [backport] (#20164) * fixes #20153; do not escape `_` for mysql * add a test * Update db_mysql.nim * Update tdb_mysql.nim Co-authored-by: Clay Sweetser <[email protected]> * [minor] don't find `"Hint: gc"` for action (#20170) * fixes links in the readme (#20167) * update the docs of arc following up #19749 (#19752) Co-authored-by: flywind <[email protected]> * fixes broken ssl tests (#20181) * bootstrap the compiler with nimPreviewSlimSystem (#20176) * bootstrap the compiler with nimPreviewSlimSystem * threads * docs: fix some spelling errors (#19816) * docs: fix some spelling errors * contributing: fix spelling error Co-authored-by: konsumlamm <[email protected]> * Update contributing.md * Update intern.md * Update manual.md * Update manual_experimental_strictnotnil.md * Update nimgrep_cmdline.txt * Update pegdocs.txt * Update testament.md * Update tut1.md Co-authored-by: konsumlamm <[email protected]> Co-authored-by: Clay Sweetser <[email protected]> * Build compiler with --noNimblePath (#20168) - Fixes #18840 * help our poor CI; don't run CI on other branches for push (#20184) * fix broken runnableExamples for getWeeksInIsoYear (#20193) Based on what I understand from [Wikipedia](https://en.wikipedia.org/wiki/ISO_week_date#Weeks_per_year), 2001 does not have 53 weeks, but 2004, 2009, 2015, 2020 do. The years 2000 and 2001 seem to be copy pasted from the `getDaysInYear` example above. The result of `getWeeksInIsoYear` also seem to match up with Wikipedia. That means these runnableExamples were never tested. Why is this the case? I only discovered this in #20091. * improve deprecation error messages (#20197) * Show beatutiful html instead of ugly markdown preview (#20196) * closes #6559; add testcase (#20200) * CI upgrade to ubuntu-20.04 (#20182) * CI upgrade to ubuntu-20.04 The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002 * Update azure-pipelines.yml * Markdown code blocks part 4 (#20189) No logic was added, just 8 more files have been migrated. * closes #15316; add testcase (#20213) * add version-1-6 and version-1-2 to triggered branches (#20214) * add version-1-6 and version-1-2 to triggered branches * Update .github/workflows/ci_packages.yml * use quote * closes #12955; add testcase (#20223) * add more Co-authored-by: konsumlamm <[email protected]> Co-authored-by: Clay Sweetser <[email protected]> Co-authored-by: flywind <[email protected]> Co-authored-by: ee7 <[email protected]> Co-authored-by: Ivan Yonchovski <[email protected]> Co-authored-by: metagn <[email protected]> Co-authored-by: Andrey Makarov <[email protected]>
Fixes bug reported in #20189 affecting nimforum.
Don't require blank line before Markdown code Fixes bug reported in #20189 affecting nimforum. (manually backported version to 1.6 from devel)
No logic was added, just 8 more files have been migrated.
Fixes bug reported in nim-lang#20189 affecting nimforum.
No logic was added, just 8 more files have been migrated.