Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build compiler with --noNimblePath #20168

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

yyoncho
Copy link
Contributor

@yyoncho yyoncho commented Aug 6, 2022

yyoncho added a commit to yyoncho/Nim that referenced this pull request Aug 8, 2022
yyoncho added a commit to yyoncho/Nim that referenced this pull request Aug 8, 2022
yyoncho added a commit to yyoncho/Nim that referenced this pull request Aug 8, 2022
- needs nim-lang#20168 to make the stuff working

I went for this minimal solution because it seems like `compiler.nimble` and
`nimsuggest.nimble` are not in use
@Varriount Varriount merged commit ec2bc2a into nim-lang:devel Aug 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from ec2bc2a

Hint: mm: orc; threads: on; opt: speed; options: -d:release
163649 lines; 12.463s; 841.605MiB peakmem

yyoncho added a commit to yyoncho/Nim that referenced this pull request Aug 11, 2022
- needs nim-lang#20168 to make the stuff working

I went for this minimal solution because it seems like `compiler.nimble` and
`nimsuggest.nimble` are not in use
metagn pushed a commit to metagn/Nim that referenced this pull request Aug 12, 2022
ringabout added a commit that referenced this pull request Aug 15, 2022
* Improve error message for `strutils.addf` (#20157)

Co-authored-by: ringabout <[email protected]>

* fixes #20153; do not escape `_` for mysql [backport] (#20164)

* fixes #20153; do not escape `_` for mysql

* add a test

* Update db_mysql.nim

* Update tdb_mysql.nim

Co-authored-by: Clay Sweetser <[email protected]>

* [minor] don't find `"Hint: gc"` for action (#20170)

* fixes links in the readme (#20167)

* update the docs of arc following up #19749 (#19752)

Co-authored-by: flywind <[email protected]>

* fixes broken ssl tests (#20181)

* bootstrap the compiler with nimPreviewSlimSystem (#20176)

* bootstrap the compiler with nimPreviewSlimSystem

* threads

* docs: fix some spelling errors (#19816)

* docs: fix some spelling errors

* contributing: fix spelling error

Co-authored-by: konsumlamm <[email protected]>

* Update contributing.md

* Update intern.md

* Update manual.md

* Update manual_experimental_strictnotnil.md

* Update nimgrep_cmdline.txt

* Update pegdocs.txt

* Update testament.md

* Update tut1.md

Co-authored-by: konsumlamm <[email protected]>
Co-authored-by: Clay Sweetser <[email protected]>

* Build compiler with --noNimblePath (#20168)

- Fixes #18840

* help our poor CI; don't run CI on other branches for push (#20184)

* fix broken runnableExamples for getWeeksInIsoYear (#20193)

Based on what I understand from [Wikipedia](https://en.wikipedia.org/wiki/ISO_week_date#Weeks_per_year), 2001 does not have 53 weeks, but 2004, 2009, 2015, 2020 do. The years 2000 and 2001 seem to be copy pasted from the `getDaysInYear` example above. The result of `getWeeksInIsoYear` also seem to match up with Wikipedia.

That means these runnableExamples were never tested. Why is this the case? I only discovered this in #20091.

* improve deprecation error messages (#20197)

* Show beatutiful html instead of ugly markdown preview (#20196)

* closes #6559; add testcase (#20200)

* CI upgrade to ubuntu-20.04 (#20182)

* CI upgrade to ubuntu-20.04 

The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002

* Update azure-pipelines.yml

* Markdown code blocks part 4 (#20189)

No logic was added, just 8 more files have been migrated.

* closes #15316; add testcase (#20213)

* add version-1-6 and version-1-2 to triggered branches (#20214)

* add version-1-6 and version-1-2 to triggered branches

* Update .github/workflows/ci_packages.yml

* use quote

* closes #12955; add testcase (#20223)

* add more

Co-authored-by: konsumlamm <[email protected]>
Co-authored-by: Clay Sweetser <[email protected]>
Co-authored-by: flywind <[email protected]>
Co-authored-by: ee7 <[email protected]>
Co-authored-by: Ivan Yonchovski <[email protected]>
Co-authored-by: metagn <[email protected]>
Co-authored-by: Andrey Makarov <[email protected]>
@yyoncho
Copy link
Contributor Author

yyoncho commented Aug 22, 2022

@narimiran backport this one to 1.6?

narimiran pushed a commit that referenced this pull request Aug 23, 2022
@narimiran
Copy link
Member

@narimiran backport this one to 1.6?

Done.

yyoncho added a commit to yyoncho/Nim that referenced this pull request Aug 24, 2022
- needs nim-lang#20168 to make the stuff working

I went for this minimal solution because it seems like `compiler.nimble` and
`nimsuggest.nimble` are not in use
Varriount added a commit that referenced this pull request Aug 31, 2022
- needs #20168 to make the stuff working

I went for this minimal solution because it seems like `compiler.nimble` and
`nimsuggest.nimble` are not in use

Co-authored-by: Clay Sweetser <[email protected]>
yyoncho added a commit to yyoncho/Nim that referenced this pull request Feb 7, 2023
- needs nim-lang#20168 to make the stuff working

I went for this minimal solution because it seems like `compiler.nimble` and
`nimsuggest.nimble` are not in use

Co-authored-by: Clay Sweetser <[email protected]>
narimiran pushed a commit that referenced this pull request Feb 9, 2023
- needs #20168 to make the stuff working

I went for this minimal solution because it seems like `compiler.nimble` and
`nimsuggest.nimble` are not in use

Co-authored-by: Clay Sweetser <[email protected]>
(cherry picked from commit fb27734)
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
- needs nim-lang#20168 to make the stuff working

I went for this minimal solution because it seems like `compiler.nimble` and
`nimsuggest.nimble` are not in use

Co-authored-by: Clay Sweetser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to run the build_all.sh script with a nimble package install throws error
3 participants