Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #18612; apply cache and memcmp for methods in arc/orc #19749

Merged
merged 8 commits into from
Apr 26, 2022
Merged

fixes #18612; apply cache and memcmp for methods in arc/orc #19749

merged 8 commits into from
Apr 26, 2022

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Apr 26, 2022 •
edited
Loading

fixes #18612

@ringabout ringabout changed the title try using strncmp apply cache and memcmp for method in arc/orc Apr 26, 2022
@ringabout ringabout mentioned this pull request Apr 26, 2022
Closed
@ringabout ringabout changed the title apply cache and memcmp for method in arc/orc fixes #18612; apply cache and memcmp for methods in arc/orc Apr 26, 2022
@ringabout
Copy link
Member Author

uses the similar implementation as refc; ready for review

@Araq Araq merged commit 8bfc396 into nim-lang:devel Apr 26, 2022
@rockcavera
Copy link
Contributor

Very good. It's already a big improvement.

Here, now, compiling with --mm:arc is 1.78x compared to refc. But previously it was 20.15x the speed of the refc.

narimiran pushed a commit that referenced this pull request May 2, 2022
@ringabout @narimiran
fixes #18612; apply cache and memcmp for methods in arc/orc (#19749)
1788b8b 
* try using endsWith

* use memcmp

* add cache

* cleanup

* better

* minor

* fix

* improve test coverage for methods with ARC

(cherry picked from commit 8bfc396)
ringabout added a commit that referenced this pull request May 2, 2022
@ringabout
update the docs of arc following up #19749
a48a095
ringabout added a commit that referenced this pull request Aug 8, 2022
@ringabout
update the docs of arc following up #19749 (#19752)
80a0dc2 
Co-authored-by: flywind <[email protected]>
metagn pushed a commit to metagn/Nim that referenced this pull request Aug 12, 2022
@ringabout @metagn
update the docs of arc following up nim-lang#19749 (nim-lang#19752)
42474bd 
Co-authored-by: flywind <[email protected]>
ringabout added a commit that referenced this pull request Aug 15, 2022
@ringabout @konsumlamm
@Varriount @ee7 @yyoncho @metagn @a-mr
finish tasks (#20230)
52267c1 
* Improve error message for `strutils.addf` (#20157)

Co-authored-by: ringabout <[email protected]>

* fixes #20153; do not escape `_` for mysql [backport] (#20164)

* fixes #20153; do not escape `_` for mysql

* add a test

* Update db_mysql.nim

* Update tdb_mysql.nim

Co-authored-by: Clay Sweetser <[email protected]>

* [minor] don't find `"Hint: gc"` for action (#20170)

* fixes links in the readme (#20167)

* update the docs of arc following up #19749 (#19752)

Co-authored-by: flywind <[email protected]>

* fixes broken ssl tests (#20181)

* bootstrap the compiler with nimPreviewSlimSystem (#20176)

* bootstrap the compiler with nimPreviewSlimSystem

* threads

* docs: fix some spelling errors (#19816)

* docs: fix some spelling errors

* contributing: fix spelling error

Co-authored-by: konsumlamm <[email protected]>

* Update contributing.md

* Update intern.md

* Update manual.md

* Update manual_experimental_strictnotnil.md

* Update nimgrep_cmdline.txt

* Update pegdocs.txt

* Update testament.md

* Update tut1.md

Co-authored-by: konsumlamm <[email protected]>
Co-authored-by: Clay Sweetser <[email protected]>

* Build compiler with --noNimblePath (#20168)

- Fixes #18840

* help our poor CI; don't run CI on other branches for push (#20184)

* fix broken runnableExamples for getWeeksInIsoYear (#20193)

Based on what I understand from [Wikipedia](https://en.wikipedia.org/wiki/ISO_week_date#Weeks_per_year), 2001 does not have 53 weeks, but 2004, 2009, 2015, 2020 do. The years 2000 and 2001 seem to be copy pasted from the `getDaysInYear` example above. The result of `getWeeksInIsoYear` also seem to match up with Wikipedia.

That means these runnableExamples were never tested. Why is this the case? I only discovered this in #20091.

* improve deprecation error messages (#20197)

* Show beatutiful html instead of ugly markdown preview (#20196)

* closes #6559; add testcase (#20200)

* CI upgrade to ubuntu-20.04 (#20182)

* CI upgrade to ubuntu-20.04 

The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002

* Update azure-pipelines.yml

* Markdown code blocks part 4 (#20189)

No logic was added, just 8 more files have been migrated.

* closes #15316; add testcase (#20213)

* add version-1-6 and version-1-2 to triggered branches (#20214)

* add version-1-6 and version-1-2 to triggered branches

* Update .github/workflows/ci_packages.yml

* use quote

* closes #12955; add testcase (#20223)

* add more

Co-authored-by: konsumlamm <[email protected]>
Co-authored-by: Clay Sweetser <[email protected]>
Co-authored-by: flywind <[email protected]>
Co-authored-by: ee7 <[email protected]>
Co-authored-by: Ivan Yonchovski <[email protected]>
Co-authored-by: metagn <[email protected]>
Co-authored-by: Andrey Makarov <[email protected]>
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
update the docs of arc following up nim-lang#19749 (nim-lang#19752)
b8ab2c6 
Co-authored-by: flywind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method dispatch is slow
3 participants
@ringabout @rockcavera @Araq