Fix probs with latest gecko-driver(selenium/standalone-firefox:3.5.0 and above)

[yak80]

Issue: Element is present but cannot be read #1600

[gitChristian]

I just tried this with selenium 3.7.1, geckodriver 0.19.1, nightwatch 0.19.16 and it doesn't work.

Error while running waitForElementVisible command: Element.fromSelector is not a function
...
at Module.call (/usr/lib/node_modules/nightwatch/lib/runner/module.js:62:34)
at /usr/lib/node_modules/nightwatch/lib/runner/testcase.js:70:29
at _fulfilled (/usr/lib/node_modules/nightwatch/node_modules/q/q.js:834:54)
at self.promiseDispatch.done (/usr/lib/node_modules/nightwatch/node_modules/q/q.js:863:30)
at Promise.promise.promiseDispatch (/usr/lib/node_modules/nightwatch/node_modules/q/q.js:796:13)
at /usr/lib/node_modules/nightwatch/node_modules/q/q.js:556:49
at runSingle (/usr/lib/node_modules/nightwatch/node_modules/q/q.js:137:13)
at flush (/usr/lib/node_modules/nightwatch/node_modules/q/q.js:125:13)
at _combinedTickCallback (internal/process/next_tick.js:73:7)

[mAiNiNfEcTiOn]

@beatfactor please merge this as Nightwatch's current state is breaking the compatibility with the most recent drivers' implementations (following the spec).

A lot of us are considering using this fork of the project because you've been out of the scene when it comes to merge PRs.

Issues like #1644, #1600 and #1558 are waiting for this fix.

#nopressure

[Zechtitus]

Any word on if this is able to go into a release... And if not - why?

[beatfactor]

It's impossible for me to merge this PR as it is not following the contributing guidelines, like a simple unit test. There's also hardcoded uuid in there, so clearly I cannot accept it in this state.

[Zechtitus]

@yak80 - possible we can fix this MR to the contributing guidelines standard? :)

as far as the hardcoded uuid - is this not coming direct from the webdriver standards? (https://www.w3.org/TR/2016/WD-webdriver-20161129/#h-elements)

[mAiNiNfEcTiOn]

@beatfactor read the spec please... https://www.w3.org/TR/webdriver/#h-elements

Also, I just cloned this master's repo and ran the npm test:

Which is not passing. (Note: I'm on Node 8.9.1). With Node 6, it passes:

[mAiNiNfEcTiOn]

@beatfactor Can you also explain to me, how is it possible that your checks are passing here, but the mocks.json must be updated? From his master:

Tests are failing :|

[beatfactor]

@mAiNiNfEcTiOn please don't pollute the thread, I am removing your screenshots.

[beatfactor]

@Zechtitus ok then, I'll merge this.

[beatfactor]

This fix is now in v0.9 release branch and will be published to npm shortly.

@yak80 sorry I couldn't merge this in its original form, your branch was based on master and there are some changes there that shouldn't be released yet.

[Zechtitus]

@beatfactor thanks for the merge!