Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/1600 fix element property #1656

Conversation

mAiNiNfEcTiOn
Copy link

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with addressing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix)
  • If you're fixing a bug also create an issue if one doesn't exist yet
  • If it's a new feature explain why do you think it's necessary
  • If your change include drastic or low level changes please discuss them to make sure they will be accepted and what the impact will be
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will not make it in very quick, if at all.
  • Do not include changes that are not related to the issue at hand
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.
  • Add unit tests

Closes #1600

/cc @yak80

yak80 and others added 3 commits October 2, 2017 13:26
…efox

Fix probs with selenium/standalone-firefox:3.5.0
…function to be able to test it if necessary. Updates the mocks.json to match the changes
@beatfactor
Copy link
Member

Thanks, but I'm already reviewing #1604.

@beatfactor beatfactor closed this Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element is present but cannot be read
3 participants