-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nightwatch does not work with selenium node-firefox-debug:3.5+ #1628
Comments
I'm not sure if this is the same issue or not, but... I am using Selenium 3.7.1 and Firefox 56, my tests work fine in Chrome 60, but when I try the same tests with no changes, firefox is unable to find any of the selectors. I see this repeatedly in the log of the selenium server and then it fails the test with the error message: Timed out while waiting for element to be visible for 10000 milliseconds. - Expected "visible" but got: "not visible" Here is the selenium log: |
@vanpatton does it work with the branch provided by yak80? |
When you responded, thats what I was trying and yes it does fix it. I totally missed the end of his post where he had a fix. |
Same here. |
#1600 issue was re-opened, should we close this one? |
The question is more about, why on Earth is this PR #1604 still open? Shouldn't it have been merged by now? It does meet the specs: https://w3c.github.io/webdriver/webdriver-spec.html#x11-elements Where it says:
|
@mAiNiNfEcTiOn, exactly. @straris, this is different issue, that is opened specially for PR #1604, so it must remain opened. |
Double checking - did this make it into 0.9.19? I am running into other issues regarding firefox which are still locking me into having to use 3.4 #1683 |
@Zechtitus I updated my project to latest nightwatch version - still having this problem . Meta -Image(s): Expected Behavior -Firefox node not driopping connection Actual Behavior -
Using nightwatch JS as testframework:
Error retrieving a new session from the selenium server Connection refused! Is selenium server started? |
@beatfactor - Hey would you have any idea on why this is an issue? |
@beatfactor Looks like the issue was referenced in another repository too, pointing to Nightwatch. I can confirm, running firefox in a selenium grid setup fails but not in standalone Setup: Also broken on 0.9.17 |
When I tested a few months ago, if you ran the ªselenium grid* with the config Now, the way I see this is, either the Gecko driver project fixes its payload to retrieve the same as the other browsers OR all drivers should align on the payload responses for all procedures under the WebDriver's standard. |
@mAiNiNfEcTiOn I didn't have any luck with |
first, my bad, the casing was incorrect. It should be if you're using the docker-selenium image, bear in mind that they do not allow to change it via the docker-run: It's running with this config: https://github.com/SeleniumHQ/docker-selenium/blob/master/Hub/generate_config (Check bottom of this file: https://hub.docker.com/r/selenium/hub/~/dockerfile/ ) The best way to test it is locally, setting a hub: |
@mAiNiNfEcTiOn indeed I followed exactly what you suggested, I skipped the whole docker setup and tried it with a local hub and node.
Let me know if you get the chance to test it too. |
@mAiNiNfEcTiOn , @Zechtitus I managed to workaround the issue by setting the |
@straris @mAiNiNfEcTiOn in docker-compose you can try for both hub and nodes. I'm currently unable to access computer for a while because of vacation but would appreciate if somebody could tell me if it works. environment: |
@ViljarVoidula no luck with this setting on hub or the firefox node |
@Zechtitus did you have give it a try with 3.8.1? |
@straris - I was using the latest flag as of last night. I will fiddle some more today if I get the chance. |
@Zechtitus |
still no luck. Here is the details from the hub console
and the logs from the firefox docker:
and the hub docker logs:
|
is this issue related to #1456? |
@straris tried pretty much everything I can with the enablePassThrough setting and no luck. Tried this on hub, firefox, both and no change in the Connection refused status being returned from nightwatch when trying to connect to firefox. BTW - SeleniumHQ/docker-selenium#647 seems to indicate that setting this would show no difference in the console. |
@Zechtitus that is interesting, in my case the only thing I did was setting enablePassThrough to both hub and nodes, although according to a comment in the issue you mentioned:
It looks like it's not a nightwatch issue though, should we create one for selenium? |
@straris - think this is a nightwatch issue and how firefox works with it. You can make firefox work with latest standalone-firefox but not the node variants. I also read that enablePassThrough was a depreciated feature which will be removed shortly... If not already in subsequent docker releases for selenium |
From my experience it is almost always related to compatibility issues between the version(s) of Firefox and the used webdriver binary. I can highly recommend to have a look at Zalenium regards |
@davidlinse |
For what it is worth "SE_OPTS=-enablePassThrough false" on testing for me today does not appear to be working for me with:
The result is:
Also 3.9 was just released and that drops passthrough entirely so doesn't work there so a new approach is needed to handle the webdriver session with firefox. |
Candidate resolution of issue #33, "Resolve Travis CI Nightwatch failures since #32 resolution". Moving away from PhantomJS as its development has been discontinued (ariya/phantomjs#15344), its latest and final version (2.1.1) does not support Web Fonts (https://stackoverflow.com/q/23404658/1840078) which were recently added to this project, it does not work with any version of Selenium beyond 3.5.3 save for 3.7.1 based on my own testing (perhaps related: Firefox on Selenium 3.5+ breakage: nightwatchjs/nightwatch#1628), local download of Google Fonts is hard to automate and PhantomJS user-agent cannot be changed without likely modifications to Nightwatch. Also: updated gulp-nightwatch to latest non-broken version - 1.0.0 is broken (tatsuyafw/gulp-nightwatch#55)... and depends on [email protected] which is still in beta. Replaced slower and less reliable pause(time) calls with .waitForElementPresent(selector, time) calls to increase e2e test clarity and reliability.
This issue has been automatically marked as stale because it has not had any recent activity. |
should be fixed in v1.0.14 |
This issue was referenced before in #1600 and was closed as the original author was able to go back to 3.4. Not being able to use nightwatch with a current firefox build is still an issue though.
I tried @yak80 solution in that issue and found it to work as expected. Would like this issue reopened as we are still stuck using 3.4 which is quite dated.
a quick recap of the issue. If you try to use various methods like click with the 3.6 selenium docker version you will get an error message like this:
The text was updated successfully, but these errors were encountered: