Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a less angular and tapered, more blocky font for card indices in user interface #32

Closed
markafitzgerald1 opened this issue May 10, 2018 · 0 comments
Closed

Use a less angular and tapered, more blocky font for card indices in user interface #32

markafitzgerald1 opened this issue May 10, 2018 · 0 comments
Assignees
@markafitzgerald1

Comments

@markafitzgerald1
Copy link
Owner

markafitzgerald1 commented May 10, 2018 •
edited
Loading

Default Times Roman or similar font unnecessarily detailed. Also, most if not all playing cards use sans serif or serif with non-tapered serifs fonts in my experience. Candidate fonts: https://fonts.google.com/specimen/Arvo. https://fonts.google.com/specimen/Roboto+Slab, https://fonts.google.com/specimen/Kadwa.
@markafitzgerald1 markafitzgerald1 self-assigned this May 10, 2018
@markafitzgerald1 markafitzgerald1 changed the title Use sans serif font in user interface Use a less angular and tapered, more blocky font in user interface May 10, 2018
@markafitzgerald1 markafitzgerald1 changed the title Use a less angular and tapered, more blocky font in user interface Use a less angular and tapered, more blocky font for card indices in user interface May 10, 2018
markafitzgerald1 added a commit that referenced this issue Jul 15, 2018
@markafitzgerald1
Move e2e tests from PhantomJS to headless Chrome
7755613 
Candidate resolution of issue #33, "Resolve Travis CI Nightwatch
failures since #32 resolution".  Moving away from PhantomJS as its
development has been discontinued
(ariya/phantomjs#15344), its latest and final
version (2.1.1) does not support Web Fonts
(https://stackoverflow.com/q/23404658/1840078) which were recently
added to this project, it does not work with any version of Selenium
beyond 3.5.3 save for 3.7.1 based on my own testing (perhaps related:
Firefox on Selenium 3.5+ breakage:
nightwatchjs/nightwatch#1628), local download
of Google Fonts is hard to automate and PhantomJS user-agent cannot be
changed without likely modifications to Nightwatch.

Also: updated gulp-nightwatch to latest non-broken version - 1.0.0 is
broken (tatsuyafw/gulp-nightwatch#55)... and
depends on [email protected] which is still in beta.

Replaced slower and less reliable pause(time) calls with
.waitForElementPresent(selector, time) calls to increase e2e test
clarity and reliability.
@markafitzgerald1 markafitzgerald1 mentioned this issue Jul 16, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markafitzgerald1 markafitzgerald1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markafitzgerald1