fix(store): remove `?` from `ctx` parameter of lifecycle hooks since they are never undefined #1889

arturovt · 2022-07-31T19:11:05Z

This commit updates the signature of NgxsOnInit and NgxsAfterBootstrap interfaces. The ctx parameter was marked as optional initially by some reason. But it's never optional since we pass the ctx parameter. This isn't a breaking change.

bundlemon · 2022-07-31T19:18:19Z

BundleMon

Unchanged files (6)

Status	Path	Size	Limits
✅	fesm5/ngxs-store.js	133.95KB	145KB / +0.5%
✅	fesm2015/ngxs-store.js	114.98KB	125KB / +0.5%
✅	fesm5/ngxs-store-operators.js	10.07KB	15KB / +0.5%
✅	fesm2015/ngxs-store-operators.js	9.94KB	15KB / +0.5%
✅	fesm5/ngxs-store-internals.js	6.58KB	20KB / +0.5%
✅	fesm2015/ngxs-store-internals.js	5.65KB	20KB / +0.5%

Total files change -4B 0%

Unchanged groups (6)

Status	Path	Size	Limits
✅	@ngxs/store(esm5)[gzip] _{./esm5/*/.js}	175.32KB	+1%
✅	@ngxs/store(esm2015)[gzip] _{./esm2015/*/.js}	168.81KB	+1%
✅	@ngxs/store(umd)[gzip] _{./bundles/*.umd.js}	39.67KB	+1%
✅	@ngxs/store(fesm5)[gzip] _./fesm5/*.js	29.04KB	+1%
✅	@ngxs/store(fesm2015)[gzip] _{./fesm2015/*.js}	26.67KB	+1%
✅	@ngxs/store(umd.min)[gzip] _{./bundles/*.umd.min.js}	13.72KB	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2022-07-31T19:18:22Z

BundleMon (NGXS Plugins)

Unchanged files (28)

Status	Path	Size	Limits
✅	Plugins(umd)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. js}	7.71KB	+1%
✅	Plugins(umd)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.js}	7.24KB	+1%
✅	Plugins(umd)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.js}	6.96KB	+1%
✅	Plugins(umd)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.js}	6.87KB	+1%
✅	Plugins(umd)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.js}	6.4KB	+1%
✅	Plugins(umd)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.js}	6.16KB	+1%
✅	Plugins(umd)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. js}	5.77KB	+1%
✅	Plugins(fesm5)[gzip] _{router-plugin/fesm5/ngxs-router-plugin.js}	4.31KB	+1%
✅	Plugins(fesm2015)[gzip] _{router-plugin/fesm2015/ngxs-router-plugin.js}	4.02KB	+1%
✅	Plugins(fesm5)[gzip] _{storage-plugin/fesm5/ngxs-storage-plugin.js}	3.95KB	+1%
✅	Plugins(fesm2015)[gzip] _{storage-plugin/fesm2015/ngxs-storage-plugin.j s}	3.64KB	+1%
✅	Plugins(fesm5)[gzip] _{hmr-plugin/fesm5/ngxs-hmr-plugin.js}	3.62KB	+1%
✅	Plugins(fesm5)[gzip] _{websocket-plugin/fesm5/ngxs-websocket-plugin. js}	3.53KB	+1%
✅	Plugins(fesm2015)[gzip] _{hmr-plugin/fesm2015/ngxs-hmr-plugin.js}	3.25KB	+1%
✅	Plugins(fesm2015)[gzip] _{websocket-plugin/fesm2015/ngxs-websocket-plug in.js}	3.15KB	+1%
✅	Plugins(umd.min)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.min.js}	3.1KB	+1%
✅	Plugins(fesm5)[gzip] _{form-plugin/fesm5/ngxs-form-plugin.js}	3.04KB	+1%
✅	Plugins(fesm5)[gzip] _{devtools-plugin/fesm5/ngxs-devtools-plugin.js}	2.83KB	+1%
✅	Plugins(umd.min)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. min.js}	2.72KB	+1%
✅	Plugins(fesm2015)[gzip] _{form-plugin/fesm2015/ngxs-form-plugin.js}	2.71KB	+1%
✅	Plugins(fesm2015)[gzip] _{devtools-plugin/fesm2015/ngxs-devtools-plugin .js}	2.65KB	+1%
✅	Plugins(fesm5)[gzip] _{logger-plugin/fesm5/ngxs-logger-plugin.js}	2.48KB	+1%
✅	Plugins(umd.min)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.min. js}	2.41KB	+1%
✅	Plugins(fesm2015)[gzip] _{logger-plugin/fesm2015/ngxs-logger-plugin.js}	2.37KB	+1%
✅	Plugins(umd.min)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.min.js}	2.32KB	+1%
✅	Plugins(umd.min)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.min.js}	2.18KB	+1%
✅	Plugins(umd.min)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. min.js}	1.95KB	+1%
✅	Plugins(umd.min)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.min.js}	1.86KB	+1%

No change in files bundle size

Unchanged groups (6)

Status	Path	Size	Limits
✅	All Plugins(esm5)[gzip] _{./-plugin/esm5/**/.js}	121.25KB	+1%
✅	All Plugins(esm2015)[gzip] _{./-plugin/esm2015/**/.js}	115.91KB	+1%
✅	All Plugins(umd)[gzip] _{./-plugin/bundles/.umd.js}	47.12KB	+1%
✅	All Plugins(fesm5)[gzip] _{./-plugin/fesm5/.js}	23.75KB	+1%
✅	All Plugins(fesm2015)[gzip] _{./-plugin/fesm2015/.js}	21.79KB	+1%
✅	All Plugins(umd.min)[gzip] _{./-plugin/bundles/.umd.min.js}	16.53KB	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2022-07-31T19:18:24Z

BundleMon (Integration Projects)

Unchanged files (4)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng11-ivy/dist-integration/main.(h ash).js}	70.82KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng13-ivy/dist-integration/main.(h ash).js}	69.45KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng12-ivy/dist-integration/main.(h ash).js}	67.53KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng14-ivy/dist-integration/main.(h ash).js}	65.13KB	+1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

…they are never undefined

codeclimate · 2022-08-01T12:52:34Z

Code Climate has analyzed commit 95cb266 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.4% (0.0% change).

View more on Code Climate.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.4/3.7.5) | | [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.4/3.7.5) | | [@ngxs/store](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.4/3.7.5) | --- ### Release Notes <details> <summary>ngxs/store</summary> ### [`v3.7.5`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#375-2022-08-08) [Compare Source](ngxs/store@v3.7.4...v3.7.5) - Performance: Tree-shake no type on the action error [#1858](ngxs/store#1858) - Fix: Give back control to `developmentMode` config property [#1878](ngxs/store#1878) - Fix: Do not use `refCount()` since it makes selectable stream cold [#1883](ngxs/store#1883) - Fix: Remove `?` from `ctx` parameter of lifecycle hooks since they are never undefined [#1889](ngxs/store#1889) - Fix: Avoid incorrectly ordered state observable events [#1908](ngxs/store#1908) - Fix: Router Plugin - Prevent router overriding valid navigation [#1907](ngxs/store#1907) - Fix: Storage Plugin - Provide more meaningful error message when the storage quota exceeds [#1863](ngxs/store#1863) - Fix: Storage Plugin - Ensure the deserialization is not skipped for master key [#1887](ngxs/store#1887) - Fix: Storage Plugin - Do not re-hydrate the whole state when the feature state is added [#1887](ngxs/store#1887) - Fix: Devtools Plugin - Enable time-traveling for navigation actions [#1868](ngxs/store#1868) - Fix: Form Plugin - Prevent actions infinite loop with multiple `ngxsForm` directives [#1890](ngxs/store#1890) - Fix: Do not check if the state class is injectable within the decorator since the `ɵprov` will not exist in JIT mode [#1867](ngxs/store#1867) - Revert: revert select decorator changes and add deprecation note [#1871](ngxs/store#1871) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1497 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

arturovt requested review from markwhitfeld, kuncevic, Carniatto, poloagustin, joaqcid and splincode as code owners July 31, 2022 19:11

arturovt force-pushed the artur/chore-hooks branch from 2290307 to 29005c3 Compare August 1, 2022 10:44

arturovt changed the title ~~chore(store): remove ? from ctx parameter of lifecycle hooks since they are never undefined~~ fix(store): remove ? from ctx parameter of lifecycle hooks since they are never undefined Aug 1, 2022

arturovt added this to the v3.7.5 milestone Aug 1, 2022

fix(store): remove ? from ctx parameter of lifecycle hooks since …

385e6b3

…they are never undefined

arturovt force-pushed the artur/chore-hooks branch from afabd19 to 3374d50 Compare August 1, 2022 12:48

chore: update CHANGELOG.md

95cb266

arturovt force-pushed the artur/chore-hooks branch from 3374d50 to 95cb266 Compare August 1, 2022 12:48

markwhitfeld approved these changes Aug 1, 2022

View reviewed changes

markwhitfeld merged commit b5064f8 into master Aug 1, 2022

markwhitfeld deleted the artur/chore-hooks branch August 1, 2022 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(store): remove `?` from `ctx` parameter of lifecycle hooks since they are never undefined #1889

fix(store): remove `?` from `ctx` parameter of lifecycle hooks since they are never undefined #1889

arturovt commented Jul 31, 2022 •

edited

Loading

bundlemon bot commented Jul 31, 2022 •

edited

Loading

bundlemon bot commented Jul 31, 2022 •

edited

Loading

bundlemon bot commented Jul 31, 2022 •

edited

Loading

codeclimate bot commented Aug 1, 2022

fix(store): remove ? from ctx parameter of lifecycle hooks since they are never undefined #1889

fix(store): remove ? from ctx parameter of lifecycle hooks since they are never undefined #1889

Conversation

arturovt commented Jul 31, 2022 • edited Loading

bundlemon bot commented Jul 31, 2022 • edited Loading

BundleMon

bundlemon bot commented Jul 31, 2022 • edited Loading

BundleMon (NGXS Plugins)

bundlemon bot commented Jul 31, 2022 • edited Loading

BundleMon (Integration Projects)

codeclimate bot commented Aug 1, 2022

fix(store): remove `?` from `ctx` parameter of lifecycle hooks since they are never undefined #1889

fix(store): remove `?` from `ctx` parameter of lifecycle hooks since they are never undefined #1889

arturovt commented Jul 31, 2022 •

edited

Loading

bundlemon bot commented Jul 31, 2022 •

edited

Loading

bundlemon bot commented Jul 31, 2022 •

edited

Loading

bundlemon bot commented Jul 31, 2022 •

edited

Loading