fix(store): do not use refCount() since it makes the stream cold

[arturovt]

Issue: #1880

I don't know if there're other ways to fix that issue since using refCount() just makes the stream cold when there're no observers, but publishReplay buffers the last received value. See the issue and unit test.

The shareReplay increases the number of ticks by 1, but fixes the issue.

[codeclimate]

Code Climate has analyzed commit 9b476ff and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.3% (0.0% change).

View more on Code Climate.

[bundlemon]

BundleMon

Unchanged files (6)

Status	Path	Size	Limits
✅	fesm5/ngxs-store.js	134.05KB	145KB / +0.5%
✅	fesm2015/ngxs-store.js	115.08KB	125KB / +0.5%
✅	fesm5/ngxs-store-operators.js	10.07KB	15KB / +0.5%
✅	fesm2015/ngxs-store-operators.js	9.94KB	15KB / +0.5%
✅	fesm5/ngxs-store-internals.js	6.58KB	20KB / +0.5%
✅	fesm2015/ngxs-store-internals.js	5.65KB	20KB / +0.5%

Total files change -14B 0%

Groups updated (2)

Status	Path	Size	Limits
✅	@ngxs/store(esm5)[gzip] ./esm5/**/*.js	175.34KB (-52B -0.03%)	+1%
✅	@ngxs/store(esm2015)[gzip] ./esm2015/**/*.js	168.78KB (-66B -0.04%)	+1%

Unchanged groups (4)

Status	Path	Size	Limits
✅	@ngxs/store(umd)[gzip] ./bundles/*.umd.js	39.74KB	+1%
✅	@ngxs/store(fesm5)[gzip] ./fesm5/*.js	29.08KB	+1%
✅	@ngxs/store(fesm2015)[gzip] ./fesm2015/*.js	26.69KB	+1%
✅	@ngxs/store(umd.min)[gzip] ./bundles/*.umd.min.js	13.64KB	+1%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[bundlemon]

BundleMon (NGXS Plugins)

Unchanged files (28)

Status	Path	Size	Limits
✅	Plugins(umd)[gzip] router-plugin/bundles/ngxs-router-plugin.umd. js	7.71KB	+1%
✅	Plugins(umd)[gzip] hmr-plugin/bundles/ngxs-hmr-plugin.umd.js	6.96KB	+1%
✅	Plugins(umd)[gzip] websocket-plugin/bundles/ngxs-websocket-plugi n.umd.js	6.87KB	+1%
✅	Plugins(umd)[gzip] storage-plugin/bundles/ngxs-storage-plugin.um d.js	6.6KB	+1%
✅	Plugins(umd)[gzip] form-plugin/bundles/ngxs-form-plugin.umd.js	6.4KB	+1%
✅	Plugins(umd)[gzip] devtools-plugin/bundles/ngxs-devtools-plugin. umd.js	6.16KB	+1%
✅	Plugins(umd)[gzip] logger-plugin/bundles/ngxs-logger-plugin.umd. js	5.77KB	+1%
✅	Plugins(fesm5)[gzip] router-plugin/fesm5/ngxs-router-plugin.js	4.31KB	+1%
✅	Plugins(fesm2015)[gzip] router-plugin/fesm2015/ngxs-router-plugin.js	4.02KB	+1%
✅	Plugins(fesm5)[gzip] hmr-plugin/fesm5/ngxs-hmr-plugin.js	3.62KB	+1%
✅	Plugins(fesm5)[gzip] websocket-plugin/fesm5/ngxs-websocket-plugin. js	3.53KB	+1%
✅	Plugins(fesm5)[gzip] storage-plugin/fesm5/ngxs-storage-plugin.js	3.31KB	+1%
✅	Plugins(fesm2015)[gzip] hmr-plugin/fesm2015/ngxs-hmr-plugin.js	3.25KB	+1%
✅	Plugins(fesm2015)[gzip] websocket-plugin/fesm2015/ngxs-websocket-plug in.js	3.15KB	+1%
✅	Plugins(umd.min)[gzip] hmr-plugin/bundles/ngxs-hmr-plugin.umd.min.js	3.1KB	+1%
✅	Plugins(fesm5)[gzip] form-plugin/fesm5/ngxs-form-plugin.js	3.04KB	+1%
✅	Plugins(fesm2015)[gzip] storage-plugin/fesm2015/ngxs-storage-plugin.j s	2.98KB	+1%
✅	Plugins(fesm5)[gzip] devtools-plugin/fesm5/ngxs-devtools-plugin.js	2.83KB	+1%
✅	Plugins(umd.min)[gzip] router-plugin/bundles/ngxs-router-plugin.umd. min.js	2.72KB	+1%
✅	Plugins(fesm2015)[gzip] form-plugin/fesm2015/ngxs-form-plugin.js	2.71KB	+1%
✅	Plugins(fesm2015)[gzip] devtools-plugin/fesm2015/ngxs-devtools-plugin .js	2.65KB	+1%
✅	Plugins(fesm5)[gzip] logger-plugin/fesm5/ngxs-logger-plugin.js	2.48KB	+1%
✅	Plugins(umd.min)[gzip] form-plugin/bundles/ngxs-form-plugin.umd.min. js	2.41KB	+1%
✅	Plugins(fesm2015)[gzip] logger-plugin/fesm2015/ngxs-logger-plugin.js	2.37KB	+1%
✅	Plugins(umd.min)[gzip] storage-plugin/bundles/ngxs-storage-plugin.um d.min.js	2.23KB	+1%
✅	Plugins(umd.min)[gzip] websocket-plugin/bundles/ngxs-websocket-plugi n.umd.min.js	2.18KB	+1%
✅	Plugins(umd.min)[gzip] logger-plugin/bundles/ngxs-logger-plugin.umd. min.js	1.95KB	+1%
✅	Plugins(umd.min)[gzip] devtools-plugin/bundles/ngxs-devtools-plugin. umd.min.js	1.86KB	+1%

No change in files bundle size

Unchanged groups (6)

Status	Path	Size	Limits
✅	All Plugins(esm5)[gzip] ./-plugin/esm5/**/.js	119.1KB	+1%
✅	All Plugins(esm2015)[gzip] ./-plugin/esm2015/**/.js	113.79KB	+1%
✅	All Plugins(umd)[gzip] ./-plugin/bundles/.umd.js	46.47KB	+1%
✅	All Plugins(fesm5)[gzip] ./-plugin/fesm5/.js	23.12KB	+1%
✅	All Plugins(fesm2015)[gzip] ./-plugin/fesm2015/.js	21.13KB	+1%
✅	All Plugins(umd.min)[gzip] ./-plugin/bundles/.umd.min.js	16.44KB	+1%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[bundlemon]

BundleMon (Integration Projects)

Files updated (4)

Status	Path	Size	Limits
✅	Main bundles(Gzip) hello-world-ng12-ivy/dist-integration/main.(h ash).js	67.67KB (-59B -0.09%)	+1%
✅	Main bundles(Gzip) hello-world-ng11-ivy/dist-integration/main.(h ash).js	70.96KB (-74B -0.1%)	+1%
✅	Main bundles(Gzip) hello-world-ng13-ivy/dist-integration/main.(h ash).js	69.57KB (-88B -0.12%)	+1%
✅	Main bundles(Gzip) hello-world-ng14-ivy/dist-integration/main.(h ash).js	65.27KB (-118B -0.18%)	+1%

Total files change -339B -0.12%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[markwhitfeld]

I'm happy with this solution! Nicely done.
Just a question, does the extra tick happen once for the app, or once for every new subscription, or an extra time for every emitted change?

[arturovt]

Just a question, does the extra tick happen once for the app, or once for every new subscription, or an extra time for every emitted change?

I'm not really sure how this works in unit tests since ticks seem to be called illegibly there. I've just tested it in real app with patching tick through:

const tick = ApplicationRef.prototype.tick;
let ticksCalled = 0;
ApplicationRef.prototype.tick = function () {
  console.log(`Ticks: ${ticksCalled++}`);
  return tick.call(this);
};

Ticks are called in a normal way per each event (like clicks, timers, etc), but I don't see any difference in the amount of ticks for this change in the real app (like if I change shareReplay to refCount and back).

[markwhitfeld]

I'm happy with that. Thank you!