Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage-plugin): provide more meaningful error message when the storage quota exceeds #1863

Merged
merged 1 commit into from
Jun 22, 2022
Merged

fix(storage-plugin): provide more meaningful error message when the storage quota exceeds #1863

merged 1 commit into from
Jun 22, 2022

Conversation

arturovt
Copy link
Member

No description provided.

@arturovt arturovt force-pushed the feat/storage-quota branch 2 times, most recently from 28ee36a to 9eab0c8 Compare June 20, 2022 20:46
@markwhitfeld markwhitfeld added this to the v3.7.5 milestone Jun 22, 2022
@markwhitfeld markwhitfeld changed the title feat(storage-plugin): provide more meaningful error message when the storage quota exceeds fix(storage-plugin): provide more meaningful error message when the storage quota exceeds Jun 22, 2022
@markwhitfeld
Copy link
Member

@arturovt I have classified this as a fix instead of a feature because it doesn't offer any new capabilities of the lib.

@codeclimate
Copy link

codeclimate bot commented Jun 22, 2022

Code Climate has analyzed commit 2558327 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.2% (0.0% change).

View more on Code Climate.

@arturovt arturovt force-pushed the feat/storage-quota branch 2 times, most recently from 8c3b2b6 to 53c9928 Compare June 22, 2022 16:45
@bundlemon
Copy link

bundlemon bot commented Jun 22, 2022 •
edited
Loading

BundleMon

Unchanged files (6)
Status Path Size Limits
✅ fesm5/ngxs-store.js
 136.44KB 145KB / +0.5%
✅ fesm2015/ngxs-store.js
 117.47KB 125KB / +0.5%
✅ fesm5/ngxs-store-internals.js
 15.8KB 20KB / +0.5%
✅ fesm2015/ngxs-store-internals.js
 14.84KB 20KB / +0.5%
✅ fesm5/ngxs-store-operators.js
 10.07KB 15KB / +0.5%
✅ fesm2015/ngxs-store-operators.js
 9.94KB 15KB / +0.5%

No change in files bundle size

Unchanged groups (6)
Status Path Size Limits
✅ @ngxs/store(esm5)[gzip]
./esm5/**/*.js
 187.14KB +1%
✅ @ngxs/store(esm2015)[gzip]
./esm2015/**/*.js
 180.67KB +1%
✅ @ngxs/store(umd)[gzip]
./bundles/*.umd.js
 42.47KB +1%
✅ @ngxs/store(fesm5)[gzip]
./fesm5/*.js
 31.85KB +1%
✅ @ngxs/store(fesm2015)[gzip]
./fesm2015/*.js
 29.45KB +1%
✅ @ngxs/store(umd.min)[gzip]
./bundles/*.umd.min.js
 13.98KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Jun 22, 2022 •
edited
Loading

BundleMon (NGXS Plugins)

Files updated (4)
Status Path Size Limits
❌ Plugins(fesm2015)[gzip]
storage-plugin/fesm2015/ngxs-storage-plugin.j
s
 2.98KB (+111B +3.78%) +1%
❌ Plugins(fesm5)[gzip]
storage-plugin/fesm5/ngxs-storage-plugin.js
 3.31KB (+110B +3.36%) +1%
❌ Plugins(umd)[gzip]
storage-plugin/bundles/ngxs-storage-plugin.um
d.js
 6.6KB (+106B +1.59%) +1%
❌ Plugins(umd.min)[gzip]
storage-plugin/bundles/ngxs-storage-plugin.um
d.min.js
 2.23KB (+79B +3.58%) +1%
Unchanged files (24)
Status Path Size Limits
✅ Plugins(umd)[gzip]
router-plugin/bundles/ngxs-router-plugin.umd.
js
 7.69KB +1%
✅ Plugins(umd)[gzip]
hmr-plugin/bundles/ngxs-hmr-plugin.umd.js
 6.96KB +1%
✅ Plugins(umd)[gzip]
websocket-plugin/bundles/ngxs-websocket-plugi
n.umd.js
 6.87KB +1%
✅ Plugins(umd)[gzip]
form-plugin/bundles/ngxs-form-plugin.umd.js
 6.4KB +1%
✅ Plugins(umd)[gzip]
devtools-plugin/bundles/ngxs-devtools-plugin.
umd.js
 5.91KB +1%
✅ Plugins(umd)[gzip]
logger-plugin/bundles/ngxs-logger-plugin.umd.
js
 5.77KB +1%
✅ Plugins(fesm5)[gzip]
router-plugin/fesm5/ngxs-router-plugin.js
 4.29KB +1%
✅ Plugins(fesm2015)[gzip]
router-plugin/fesm2015/ngxs-router-plugin.js
 4.01KB +1%
✅ Plugins(fesm5)[gzip]
hmr-plugin/fesm5/ngxs-hmr-plugin.js
 3.62KB +1%
✅ Plugins(fesm5)[gzip]
websocket-plugin/fesm5/ngxs-websocket-plugin.
js
 3.53KB +1%
✅ Plugins(fesm2015)[gzip]
hmr-plugin/fesm2015/ngxs-hmr-plugin.js
 3.25KB +1%
✅ Plugins(fesm2015)[gzip]
websocket-plugin/fesm2015/ngxs-websocket-plug
in.js
 3.15KB +1%
✅ Plugins(umd.min)[gzip]
hmr-plugin/bundles/ngxs-hmr-plugin.umd.min.js
 3.1KB +1%
✅ Plugins(fesm5)[gzip]
form-plugin/fesm5/ngxs-form-plugin.js
 3.04KB +1%
✅ Plugins(fesm2015)[gzip]
form-plugin/fesm2015/ngxs-form-plugin.js
 2.71KB +1%
✅ Plugins(umd.min)[gzip]
router-plugin/bundles/ngxs-router-plugin.umd.
min.js
 2.7KB +1%
✅ Plugins(fesm5)[gzip]
devtools-plugin/fesm5/ngxs-devtools-plugin.js
 2.58KB +1%
✅ Plugins(fesm5)[gzip]
logger-plugin/fesm5/ngxs-logger-plugin.js
 2.48KB +1%
✅ Plugins(umd.min)[gzip]
form-plugin/bundles/ngxs-form-plugin.umd.min.
js
 2.41KB +1%
✅ Plugins(fesm2015)[gzip]
devtools-plugin/fesm2015/ngxs-devtools-plugin
.js
 2.4KB +1%
✅ Plugins(fesm2015)[gzip]
logger-plugin/fesm2015/ngxs-logger-plugin.js
 2.37KB +1%
✅ Plugins(umd.min)[gzip]
websocket-plugin/bundles/ngxs-websocket-plugi
n.umd.min.js
 2.18KB +1%
✅ Plugins(umd.min)[gzip]
logger-plugin/bundles/ngxs-logger-plugin.umd.
min.js
 1.95KB +1%
✅ Plugins(umd.min)[gzip]
devtools-plugin/bundles/ngxs-devtools-plugin.
umd.min.js
 1.83KB +1%

Total files change +406B +0.37%

Groups updated (6)
Status Path Size Limits
✅ All Plugins(esm5)[gzip]
./-plugin/esm5/**/.js
 118.29KB (+339B +0.28%) +1%
✅ All Plugins(esm2015)[gzip]
./-plugin/esm2015/**/.js
 112.98KB (+337B +0.29%) +1%
✅ All Plugins(fesm2015)[gzip]
./-plugin/fesm2015/.js
 20.87KB (+111B +0.52%) +1%
✅ All Plugins(fesm5)[gzip]
./-plugin/fesm5/.js
 22.85KB (+110B +0.47%) +1%
✅ All Plugins(umd)[gzip]
./-plugin/bundles/.umd.js
 46.2KB (+106B +0.22%) +1%
✅ All Plugins(umd.min)[gzip]
./-plugin/bundles/.umd.min.js
 16.4KB (+79B +0.47%) +1%

Final result: ❌

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@arturovt arturovt force-pushed the feat/storage-quota branch from 53c9928 to 0d3502d Compare June 22, 2022 17:02
@arturovt arturovt merged commit f75a554 into master Jun 22, 2022
@arturovt arturovt deleted the feat/storage-quota branch June 22, 2022 17:15
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Aug 12, 2022
Update ngxs-store monorepo to v3.7.5 (#1497)
3f5002b 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.4/3.7.5) |
| [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.4/3.7.5) |
| [@ngxs/store](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.4/3.7.5) |

---

### Release Notes

<details>
<summary>ngxs/store</summary>

### [`v3.7.5`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#&#8203;375-2022-08-08)

[Compare Source](ngxs/store@v3.7.4...v3.7.5)

-   Performance: Tree-shake no type on the action error [#&#8203;1858](ngxs/store#1858)
-   Fix: Give back control to `developmentMode` config property [#&#8203;1878](ngxs/store#1878)
-   Fix: Do not use `refCount()` since it makes selectable stream cold [#&#8203;1883](ngxs/store#1883)
-   Fix: Remove `?` from `ctx` parameter of lifecycle hooks since they are never undefined [#&#8203;1889](ngxs/store#1889)
-   Fix: Avoid incorrectly ordered state observable events [#&#8203;1908](ngxs/store#1908)
-   Fix: Router Plugin - Prevent router overriding valid navigation [#&#8203;1907](ngxs/store#1907)
-   Fix: Storage Plugin - Provide more meaningful error message when the storage quota exceeds [#&#8203;1863](ngxs/store#1863)
-   Fix: Storage Plugin - Ensure the deserialization is not skipped for master key [#&#8203;1887](ngxs/store#1887)
-   Fix: Storage Plugin - Do not re-hydrate the whole state when the feature state is added [#&#8203;1887](ngxs/store#1887)
-   Fix: Devtools Plugin - Enable time-traveling for navigation actions [#&#8203;1868](ngxs/store#1868)
-   Fix: Form Plugin - Prevent actions infinite loop with multiple `ngxsForm` directives [#&#8203;1890](ngxs/store#1890)
-   Fix: Do not check if the state class is injectable within the decorator since the `ɵprov` will not exist in JIT mode [#&#8203;1867](ngxs/store#1867)
-   Revert: revert select decorator changes and add deprecation note [#&#8203;1871](ngxs/store#1871)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTEuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE1Mi4wIn0=-->

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1497
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwhitfeld markwhitfeld markwhitfeld approved these changes

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees
No one assigned
Labels
type: bug/fix
Projects
None yet
Milestone
v3.7.5
Development

Successfully merging this pull request may close these issues.
2 participants
@arturovt @markwhitfeld