Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update architecture doc #1295

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

Jcahilltorre
Copy link
Contributor

Proposed changes

Update the description of NGF in the Architecture Overview based on the content in /docs

Closes DOC-371

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@Jcahilltorre Jcahilltorre self-assigned this Nov 30, 2023
@Jcahilltorre Jcahilltorre requested a review from a team as a code owner November 30, 2023 14:31
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 30, 2023
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jcahilltorre Jcahilltorre merged commit fdeec8f into nginxinc:docs/hugo-docs Nov 30, 2023
9 checks passed
@Jcahilltorre Jcahilltorre deleted the docs/DOC-371 branch November 30, 2023 16:28
sjberman added a commit that referenced this pull request Nov 30, 2023
* Migrate docs to docs.nginx.com (#1226)

Change docs structure and add the required files to build documentation Hugo and publish with Netlify

Rewrite existing docs to work with Hugo


---------

Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>

* fix: fix links in github docs to d-n-c (#1291)

* Fix installation docs for mismatched versions (#1287)

Problem: Our installation docs suggested installing Gateway API v1 and NGF v1, which are not compatible.

Solution: Fix the docs to mention both stable and edge versions, with proper versioning. Also updated the release process doc to ensure these are updated at release time as needed.

* Update Control Plane Configuration documentation for Hugo formatting (#1296)

This commit updates the control plane configuration documentation to
match NGINX's standardised Hugo formatting conventions: specifically,
avoiding breaking sentences across line and the use of shortcodes for a
note. There are also some minor content changes for product noun
conventions and rephrasing a few sentences.

---------

Co-authored-by: Jon Torre <[email protected]>

* docs: update architecture doc (#1295)

* docs: update architecture doc

* chore: update architecture description

---------

Co-authored-by: Alan Dooley <[email protected]>

---------

Co-authored-by: Jon Torre <[email protected]>
Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants