-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate docs to docs.nginx.com #1226
Conversation
We'll probably want to think of a better place to store the developer docs, rather than |
I'd like to double check on how much feedback (if any) this PR needs any feedback at this point. |
✅ Deploy Preview for nginx-gateway-fabric ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments that don't need to be addressed now, and a question, but otherwise looks good! Thanks! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are various linting errors returned from our pipeline that need to be fixed.
Also, we have links in the repo (like the README) that lead users to our docs. If we aren't yet publishing our docs to docs.nginx.com, then we need to update those links to the hugo content directory so users don't lose our docs reference. Do the links in the docs to other pages (the relrefs
) work when viewing in github? Or are these links only functional on the nginx docs website?
I'm just concerned that users won't be able to properly view and navigate the docs in Github while the docs are in this hugo format without yet being published to the docs website.
Followed up on this via slack. In short we can hold on until docs are ready to be published in the main docs site |
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
@kate-osborn |
I was looking at the preview linked by the netlify bot. I'll try running locally |
Local preview looks better. Thanks for the tip @pleshakov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending the linting errors
the latest preview of the branch is available here: https://hugo-docs--preview-nginx-gateway-fabric.netlify.app/nginx-gateway-fabric/ |
site/content/how-to/maintenance/upgrade-apps-without-downtime.md
Outdated
Show resolved
Hide resolved
* Migrate docs to docs.nginx.com (#1226) Change docs structure and add the required files to build documentation Hugo and publish with Netlify Rewrite existing docs to work with Hugo --------- Co-authored-by: Travis Martin <[email protected]> Co-authored-by: Travis Martin <[email protected]> Co-authored-by: Kate Osborn <[email protected]> Co-authored-by: Alan Dooley <[email protected]> Co-authored-by: Alan Dooley <[email protected]> * fix: fix links in github docs to d-n-c (#1291) * Fix installation docs for mismatched versions (#1287) Problem: Our installation docs suggested installing Gateway API v1 and NGF v1, which are not compatible. Solution: Fix the docs to mention both stable and edge versions, with proper versioning. Also updated the release process doc to ensure these are updated at release time as needed. * Update Control Plane Configuration documentation for Hugo formatting (#1296) This commit updates the control plane configuration documentation to match NGINX's standardised Hugo formatting conventions: specifically, avoiding breaking sentences across line and the use of shortcodes for a note. There are also some minor content changes for product noun conventions and rephrasing a few sentences. --------- Co-authored-by: Jon Torre <[email protected]> * docs: update architecture doc (#1295) * docs: update architecture doc * chore: update architecture description --------- Co-authored-by: Alan Dooley <[email protected]> --------- Co-authored-by: Jon Torre <[email protected]> Co-authored-by: Travis Martin <[email protected]> Co-authored-by: Travis Martin <[email protected]> Co-authored-by: Kate Osborn <[email protected]> Co-authored-by: Alan Dooley <[email protected]> Co-authored-by: Alan Dooley <[email protected]>
Proposed changes
Change docs structure and add the required files to build documentation Hugo and publish with Netlify
Rewrite existing docs to work with Hugo
Checklist
Before creating a PR, run through this checklist and mark each as complete.