Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate docs to docs.nginx.com #1226

Merged
merged 114 commits into from
Nov 29, 2023
Merged

Conversation

Jcahilltorre
Copy link
Contributor

@Jcahilltorre Jcahilltorre commented Nov 6, 2023

Proposed changes

  • Change docs structure and add the required files to build documentation Hugo and publish with Netlify

  • Rewrite existing docs to work with Hugo

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@Jcahilltorre Jcahilltorre requested a review from a team as a code owner November 6, 2023 12:59
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 6, 2023
@Jcahilltorre Jcahilltorre marked this pull request as draft November 6, 2023 13:03
docs/readme.md Outdated Show resolved Hide resolved
@sjberman
Copy link
Contributor

sjberman commented Nov 6, 2023

We'll probably want to think of a better place to store the developer docs, rather than docs-developer. We also probably want docs/proposals to be stored elsewhere (not in public docs).

@pleshakov
Copy link
Contributor

Hi @Jcahilltorre

I'd like to double check on how much feedback (if any) this PR needs any feedback at this point.
What is left or necessary to make this PR transition from Draft to Ready for Review?

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for nginx-gateway-fabric ready!

Name Link
🔨 Latest commit 19b159d
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/65492eb95393e8000805530c
😎 Deploy Preview https://deploy-preview-1226--nginx-gateway-fabric.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jcahilltorre Jcahilltorre marked this pull request as ready for review November 9, 2023 13:41
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments that don't need to be addressed now, and a question, but otherwise looks good! Thanks! 🚀

hugo/readme.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
hugo/content/building-the-images.md Outdated Show resolved Hide resolved
hugo/content/guides/advanced-routing.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are various linting errors returned from our pipeline that need to be fixed.

Also, we have links in the repo (like the README) that lead users to our docs. If we aren't yet publishing our docs to docs.nginx.com, then we need to update those links to the hugo content directory so users don't lose our docs reference. Do the links in the docs to other pages (the relrefs) work when viewing in github? Or are these links only functional on the nginx docs website?

I'm just concerned that users won't be able to properly view and navigate the docs in Github while the docs are in this hugo format without yet being published to the docs website.

hugo/go.mod Outdated Show resolved Hide resolved
hugo/makefile Outdated Show resolved Hide resolved
hugo/readme.md Outdated Show resolved Hide resolved
@Jcahilltorre
Copy link
Contributor Author

Jcahilltorre commented Nov 9, 2023

There are various linting errors returned from our pipeline that need to be fixed.

Also, we have links in the repo (like the README) that lead users to our docs. If we aren't yet publishing our docs to docs.nginx.com, then we need to update those links to the hugo content directory so users don't lose our docs reference. Do the links in the docs to other pages (the relrefs) work when viewing in github? Or are these links only functional on the nginx docs website?

I'm just concerned that users won't be able to properly view and navigate the docs in Github while the docs are in this hugo format without yet being published to the docs website.

There are various linting errors returned from our pipeline that need to be fixed.

Also, we have links in the repo (like the README) that lead users to our docs. If we aren't yet publishing our docs to docs.nginx.com, then we need to update those links to the hugo content directory so users don't lose our docs reference. Do the links in the docs to other pages (the relrefs) work when viewing in github? Or are these links only functional on the nginx docs website?

I'm just concerned that users won't be able to properly view and navigate the docs in Github while the docs are in this hugo format without yet being published to the docs website.

Followed up on this via slack. In short we can hold on until docs are ready to be published in the main docs site

hugo/README.md Outdated Show resolved Hide resolved
hugo/README.md Outdated Show resolved Hide resolved
hugo/README.md Outdated Show resolved Hide resolved
hugo/README.md Outdated Show resolved Hide resolved
hugo/README.md Outdated Show resolved Hide resolved
hugo/README.md Outdated Show resolved Hide resolved
hugo/README.md Outdated Show resolved Hide resolved
hugo/README.md Outdated Show resolved Hide resolved
Jcahilltorre and others added 2 commits November 14, 2023 12:37
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
@pleshakov
Copy link
Contributor

@kate-osborn
running docs locally using the instructions for hugo (hugo server) yields different table of contents - are you using an up to date version.

@kate-osborn
Copy link
Contributor

@kate-osborn running docs locally using the instructions for hugo (hugo server) yields different table of contents - are you using an up to date version.

I was looking at the preview linked by the netlify bot. I'll try running locally

@kate-osborn
Copy link
Contributor

kate-osborn commented Nov 28, 2023

@kate-osborn running docs locally using the instructions for hugo (hugo server) yields different table of contents - are you using an up to date version.

I was looking at the preview linked by the netlify bot. I'll try running locally

Local preview looks better. Thanks for the tip @pleshakov

Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the linting errors

@Jcahilltorre
Copy link
Contributor Author

the latest preview of the branch is available here: https://hugo-docs--preview-nginx-gateway-fabric.netlify.app/nginx-gateway-fabric/

@Jcahilltorre
Copy link
Contributor Author

Fixed lint issues
image

@sjberman sjberman enabled auto-merge (squash) November 29, 2023 15:36
@Jcahilltorre Jcahilltorre changed the base branch from main to docs/hugo-docs November 29, 2023 16:10
@sjberman sjberman merged commit 110df75 into nginxinc:docs/hugo-docs Nov 29, 2023
23 checks passed
@Jcahilltorre Jcahilltorre deleted the hugo-docs branch November 29, 2023 16:12
sjberman added a commit that referenced this pull request Nov 30, 2023
* Migrate docs to docs.nginx.com (#1226)

Change docs structure and add the required files to build documentation Hugo and publish with Netlify

Rewrite existing docs to work with Hugo


---------

Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>

* fix: fix links in github docs to d-n-c (#1291)

* Fix installation docs for mismatched versions (#1287)

Problem: Our installation docs suggested installing Gateway API v1 and NGF v1, which are not compatible.

Solution: Fix the docs to mention both stable and edge versions, with proper versioning. Also updated the release process doc to ensure these are updated at release time as needed.

* Update Control Plane Configuration documentation for Hugo formatting (#1296)

This commit updates the control plane configuration documentation to
match NGINX's standardised Hugo formatting conventions: specifically,
avoiding breaking sentences across line and the use of shortcodes for a
note. There are also some minor content changes for product noun
conventions and rephrasing a few sentences.

---------

Co-authored-by: Jon Torre <[email protected]>

* docs: update architecture doc (#1295)

* docs: update architecture doc

* chore: update architecture description

---------

Co-authored-by: Alan Dooley <[email protected]>

---------

Co-authored-by: Jon Torre <[email protected]>
Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants