Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation docs for mismatched versions #1287

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

sjberman
Copy link
Contributor

Problem: Our installation docs suggested installing Gateway API v1 and NGF v1, which are not compatible.

Solution: Fix the docs to mention both stable and edge versions, with proper versioning. Also updated the release process doc to ensure these are updated at release time as needed.

Closes #1280
Closes #1284

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner November 29, 2023 20:04
@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Nov 29, 2023
deploy/helm-chart/README.md Outdated Show resolved Hide resolved
deploy/helm-chart/README.md Outdated Show resolved Hide resolved
site/content/includes/installation/install-gateway-crds.md Outdated Show resolved Hide resolved
Problem: Our installation docs suggested installing Gateway API v1 and NGF v1, which are not compatible.

Solution: Fix the docs to mention both stable and edge versions, with proper versioning. Also updated the release process doc to ensure these are updated at release time as needed.
@sjberman sjberman force-pushed the docs/version-mismatch branch from b5ab2ed to c2f5de8 Compare November 30, 2023 15:04
@sjberman sjberman merged commit e886318 into nginxinc:docs/hugo-docs Nov 30, 2023
15 checks passed
@sjberman sjberman deleted the docs/version-mismatch branch November 30, 2023 15:09
sjberman added a commit that referenced this pull request Nov 30, 2023
* Migrate docs to docs.nginx.com (#1226)

Change docs structure and add the required files to build documentation Hugo and publish with Netlify

Rewrite existing docs to work with Hugo


---------

Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>

* fix: fix links in github docs to d-n-c (#1291)

* Fix installation docs for mismatched versions (#1287)

Problem: Our installation docs suggested installing Gateway API v1 and NGF v1, which are not compatible.

Solution: Fix the docs to mention both stable and edge versions, with proper versioning. Also updated the release process doc to ensure these are updated at release time as needed.

* Update Control Plane Configuration documentation for Hugo formatting (#1296)

This commit updates the control plane configuration documentation to
match NGINX's standardised Hugo formatting conventions: specifically,
avoiding breaking sentences across line and the use of shortcodes for a
note. There are also some minor content changes for product noun
conventions and rephrasing a few sentences.

---------

Co-authored-by: Jon Torre <[email protected]>

* docs: update architecture doc (#1295)

* docs: update architecture doc

* chore: update architecture description

---------

Co-authored-by: Alan Dooley <[email protected]>

---------

Co-authored-by: Jon Torre <[email protected]>
Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants