-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update voc4cat-description and add sample & pid4cat concepts #117
Conversation
To track the mapping bug, I created an issue nfdi4cat/voc4cat-tool#241 |
86ba240
to
41e7b07
Compare
41e7b07
to
5572add
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are only a few small changes needed I think:
URI | Concept | Change proposed |
---|---|---|
voc4cat_0005016 | data object | Is there an extra space between the two sentences in the definition? |
voc4cat_0005018 | data relation | Typo: relatons |
voc4cat_0005051 | pid4catstatus | Should it be pid4cat status? |
voc4cat_0005054 | obsoleted | Do we need "(PID)" in the definition? Because in the other relations we only have "persistent identifier" |
voc4cat_0005058 | statistical sample | Typo: selecetion |
Checking the docs-preview for this PR I also recognized some issues with the hierarchy. This, some other typos and all of @nmoust´s points from the review are fixed now. I also changed the definitions of the children of "PID resource categories" to start with "A PID resource category...". This adds some duplication but it helps to understand the meaning of the concepts without checking their location in the hierarchy. I believe such extended definition is especially useful for concepts that have a general word like sample as preferred label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dalito I think that everything looks good now. I will approve the changes.
@dalito: Shall I click "Rebase and merge" after the review or would you like to do it? |
I will do it. One point I am still thinking about is adding qualifiers like so Update: I decided against adding classifiers, as their presence interferes with other applications that want to use concept definitions. For this reason, using qualifiers should be limited to a few exceptional cases like the one in the guidelines. |
This PR
material sample
spatio-temporal sample
statistical sample
resource relation
and narrower conceptsPID resource categories
and narrower conceptspid4cat status
and narrower conceptsvoc4cat:0007038
to "sample mass" (from just "mass"). Also improved its definition (weight≠mass).Closes #115
Closes #116